Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update theme for inline code and code blocks #530

Open
WillB97 opened this issue Oct 12, 2023 · 1 comment · May be fixed by #651
Open

Update theme for inline code and code blocks #530

WillB97 opened this issue Oct 12, 2023 · 1 comment · May be fixed by #651
Assignees
@RealOrangeOne

Comments

@WillB97
Copy link
Contributor

WillB97 commented Oct 12, 2023

The current theme makes the inline code blobs looks very similar to regular text and certain highlighting has poor contrast.

image

image
@PeterJCLaw
Copy link
Member

From a quick look it seems this is due to the background is provided by the syntax highlighter's CSS, and then only for code blocks (rather than inline). We could probably change this, however doing so in a way which doesn't interfere with the highlighter could get interesting.

@RealOrangeOne RealOrangeOne self-assigned this Dec 10, 2024
@RealOrangeOne RealOrangeOne moved this from Refinement to In Progress in Competitor Resources Improvements Dec 10, 2024
@RealOrangeOne RealOrangeOne linked a pull request Dec 10, 2024 that will close this issue
Open
@RealOrangeOne RealOrangeOne moved this from In Progress to Review in Competitor Resources Improvements Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RealOrangeOne RealOrangeOne

Labels
None yet
Projects
Competitor Resources Improvements
Status: Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve syntax highlighting srobo/docs
3 participants
@PeterJCLaw @RealOrangeOne @WillB97