Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to the geography schema #69

Closed
davidamichelson opened this issue Feb 10, 2020 · 5 comments
Closed

Updates to the geography schema #69

davidamichelson opened this issue Feb 10, 2020 · 5 comments
Assignees

Comments

@davidamichelson
Copy link

See #3

@davidamichelson davidamichelson changed the title Add @subtype="representative" to the geographyt schema Add @subtype="representative" to the geography schema Feb 10, 2020
@wlpotter
Copy link
Contributor

@dlschwartz I've compiled a list of the remaining schema changes we would like

  • allow @subtype="representative" on tei:location elements (full xpath: /TEI/text/body/listPlace/place/location). See Add @subtype="representative" to the manual #3
  • the @resp attribute, which is now allowed on both tei:placeName and tei:location elements, should allow the attribute value to be the string "https://bqgazetteer.bethmardutho.org". For tei:location elements, this seems to be true. However, on tei:placeName elements, @resp="https://bqgazetteer.bethmardutho.org" is invalid (the schema expects only the string "http://syriaca.org")
  • The schema says that tei:principal is 'not allowed anywhere'. We would like to include this in the tei:titleStmt (full xpath: /TEI/teiHeader/fileDesc/titleStmt/principal). This element follows the tei:funder and precedes the tei:editor elements.
  • The schema expects a tei:seriesStmt, which the BQG records will not have.

Please let me know if any of the above is unclear. Thanks much!

@wlpotter wlpotter changed the title Add @subtype="representative" to the geography schema Updates to the geography schema Feb 10, 2020
dlschwartz added a commit to srophe/draft-data that referenced this issue Apr 9, 2020
This should address the scheme changes requested here: srophe/bethqatraye-data#69
@dlschwartz
Copy link

@wlpotter @davidamichelson A quick initial test suggests that this commit resolves the changes requested here. Can you please test this a bit more widely and let me know if you need any additional changes. You can close the issue when you're satisfied.

@wlpotter
Copy link
Contributor

@dlschwartz I checked a couple more records, and this looks to be fixed. Thanks!

@wlpotter
Copy link
Contributor

Reopening to remind myself to break these out into "everywhere" and "bqg-specific" changes and making separate issues for each.

@wlpotter
Copy link
Contributor

These have been split out into
#74 #75 #76 and #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants