We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CecConnection::transmit will fail with libcec version x (TODO) when trying to transmit command having data packet of maximum size
The crash occurs in raspberry pi libcec adapter code.
https://github.com/Pulse-Eight/libcec/blob/master/src/libcec/adapter/RPi/RPiCECAdapterMessageQueue.cpp
Possible failure reason (not verified):
cec_adapter_message_state CRPiCECAdapterMessageQueue::Write(const cec_command &command, bool &bRetry, uint32_t iLineTimeout, bool bIsReply, VC_CEC_ERROR_T &vcReply) <SNIP> #if defined(RPI_USE_SEND_MESSAGE2) <SNIP> #else <SNIP> uint8_t payload[32]; <SNIP> for (uint8_t iPtr = 0; iPtr < command.parameters.size; iPtr++) payload[iPtr + 1] = command.parameters.At(iPtr); } <SNIP> #fi
However, command.parameters can be up to 64 uint8_t cectypes.h --> payload local variable is not large enough!
command.parameters
uint8_t
payload
TODO
The text was updated successfully, but these errors were encountered:
Discussion on max payload size in the context of Pulse8 adapter Pulse-Eight/libcec#443
Sorry, something went wrong.
Upstream issue created Pulse-Eight/libcec#602
No branches or pull requests
Bug description
CecConnection::transmit will fail with libcec version x (TODO) when trying to transmit command having data packet of maximum size
The crash occurs in raspberry pi libcec adapter code.
https://github.com/Pulse-Eight/libcec/blob/master/src/libcec/adapter/RPi/RPiCECAdapterMessageQueue.cpp
Possible failure reason (not verified):
However,
command.parameters
can be up to 64uint8_t
cectypes.h -->payload
local variable is not large enough!To Reproduce
TODO
Expected behavior
Screenshots
Environment
Additional context
The text was updated successfully, but these errors were encountered: