Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GR5 | Validation 1 | AllowedLocationInitiativeId config.json field #314

Closed
MathesonSho opened this issue Dec 16, 2024 · 1 comment · Fixed by #348
Closed

GR5 | Validation 1 | AllowedLocationInitiativeId config.json field #314

MathesonSho opened this issue Dec 16, 2024 · 1 comment · Fixed by #348
Assignees
Labels
bug Something isn't working Client Reported Client reported the issue (either bugfix needed or enhancement needed in their view) essential Enhancement or fix(es) that needs attention and time Iteration #1 Before V2.0 go-live PriorityForAssignees -High question Further information is requested

Comments

@MathesonSho
Copy link
Contributor

MathesonSho commented Dec 16, 2024

Describe the bug

In the instructions it says we can use "N/A" but that doesn't work.

If we point to the initiative we do have, we have a pattern match fail because the code looks for initiatives with an ID that matches the pattern "/(subscriptions/[a-fA-F0-9]{8}-(?:[a-fA-F0-9]{4}-){3}[a-fA-F0..." basically an initiative defined on a sub.

Our initiative is defined on a management group as high as we can and then assigned at the correct level as per best practices. Its ID looks like:"/providers/Microsoft.Management/managementGroups/OOOOO/providers/Microsoft.Authorization/policySetDefinitions/SSC-ReEEEE_LoCCCC_RRRRRR""

Azure CaC version
v2.1.2

**Additional Context/ Question"
Please book a discussion session with operations. Done.
See request in below comments.

@MathesonSho MathesonSho added bug Something isn't working question Further information is requested essential Enhancement or fix(es) that needs attention and time Client Reported Client reported the issue (either bugfix needed or enhancement needed in their view) Iteration #1 Before V2.0 go-live labels Dec 16, 2024
@MathesonSho
Copy link
Contributor Author

Request: Update the regex format to only accept management group/ root tenant level format. For example: /providers/Microsoft.Management/managementGroups/252afaf3-eb71-4f05-8da2-279c8b2466b7/providers/Microsoft.Authorization/policySetDefinitions/64f0399fa4b14227856a4335 in 163gccspm.

Question: If the client doesn't need to fill in the config.json allowed location initiative parameter- should it be empty, left as-is or add "N/A"?

Current config.json has the following filled in.
"allowedLocationInitiativeId": "/subscriptions/64011d17-0f22-40ce-b4da-c577a10877f3/providers/Microsoft.Authorization/policySetDefinitions/4a98b4d5524141beaaf88e93",

@MathesonSho MathesonSho changed the title GR5 | Validation 1 | Question About AllowedLocationInitiativeId config.json field GR5 | Validation 1 | AllowedLocationInitiativeId config.json field Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Client Reported Client reported the issue (either bugfix needed or enhancement needed in their view) essential Enhancement or fix(es) that needs attention and time Iteration #1 Before V2.0 go-live PriorityForAssignees -High question Further information is requested
Projects
None yet
3 participants