Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default child image #169

Closed
lkeegan opened this issue Nov 14, 2024 · 2 comments · Fixed by #172
Closed

Remove default child image #169

lkeegan opened this issue Nov 14, 2024 · 2 comments · Fixed by #172
Labels
backend enhancement New feature or request frontend

Comments

@lkeegan
Copy link
Member

lkeegan commented Nov 14, 2024

If there is no child image uploaded, then no image should be displayed
@lkeegan lkeegan added enhancement New feature or request frontend backend labels Nov 14, 2024
lkeegan added a commit that referenced this issue Nov 15, 2024
@lkeegan
Refactor image files handling
b70c2d2 
- backend
  - add sub-folders to static files directory
    - child images: PRIVATE / children / {child_id}.jpg
    - milestone images: STATIC / m / {milestone_image_id}.jpg
    - milestone group images: STATIC / mg / {milestone_group_id}.jpg
    - i18n translations: STATIC / i18n / {language_id}.json
  - add functions to utils to generate these paths from the corresponding id
  - refactor some child endpoints
  - remove `filename` and `approved` fields from MilestoneImage
    - filename is redundant
    - I think approved can be done better with a separate model for user-provided images waiting for admin approval (not in this PR)
  - remove default child image, instead return 404
    - resolves #169
  - rename databse from milestones.db -> mondey.db
- frontend
  - update image urls
  - ChildrenGallery
    - don't display error if child doesn't have an image
    - use URL.createObjectURL instead of FileReader
@lkeegan lkeegan mentioned this issue Nov 15, 2024
Merged
@MaHaWo
Copy link
Collaborator

MaHaWo commented Nov 15, 2024

do we need images at all now? (thinking of #154 )

@lkeegan
Copy link
Member Author

lkeegan commented Nov 15, 2024

My understanding was that child images should be supported, but if the user doesn't provide one that we shouldn't use a generic one. And #154 I understood as being just the background color for the child card?

@MaHaWo MaHaWo closed this as completed in f865b17 Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend enhancement New feature or request frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor image files handling ssciwr/mondey
2 participants
@lkeegan @MaHaWo