Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document add custom colormap to Geo2Grid IR channel #647

Open
djhoese opened this issue Oct 11, 2023 · 9 comments
Open

Document add custom colormap to Geo2Grid IR channel #647

djhoese opened this issue Oct 11, 2023 · 9 comments
Assignees
Milestone

Comments

@djhoese
Copy link
Member

djhoese commented Oct 11, 2023

In an effort to not make users upset, we don't want to change the default enhancement for all IR channels by adding colormaps. Instead, we plan on documenting how to add a custom colormap via a custom enhancement configuration in the PDF documentation and website. This could/should include mentioning replacing/overwriting the existing enhancement (meaning "C07" is still called "C07") and also adding a new "single band" composite that adds this colormapped version under a new name (ex. "C07_color").

@djhoese djhoese added this to the Geo2Grid 1.2 milestone Oct 11, 2023
@djhoese djhoese self-assigned this Oct 11, 2023
@djhoese
Copy link
Member Author

djhoese commented Oct 12, 2023

From the gitlab geosphere issue related to this and adopting a custom configuration only in geosphere:

@graemely's question:

Could "C07_color" be added as a non-default product, i.e. so it's not generated by default but a user can still specify it by keyword with an out-of-the-box install?

My response:

We'd then have to have C??_color for every IR channel and it would be listed in --list-products. So the 3 options I see are:

  1. Change defaults
  2. Add additional "composites" for the colorized versions of every IR channel (longer products list)
  3. Document how to do it yourself

We should maybe have this conversation on the github issue.

@graemely
Copy link

Yes, there would be a C??_color for every IR channel, but I was thinking it would only be listed in --list-products-all (not --list-products). Is there a reason to want to keep the list of non-default products short?

@djhoese
Copy link
Member Author

djhoese commented Oct 12, 2023

Hhhmm I think they'd be considered and listed as "custom user products" if they aren't considered "supported G2G products" and that's with the plain --list-products option too.

For keeping the list short: user confusion is probably the biggest one.

@graemely
Copy link

"Custom user products" sounds to me like something the user created.

But regardless, I would argue we should plan to continue adding products that we think will have value for users and that have been vetted in some way. Maybe it should be a requirement that there is some documentation that we can link users to.

@djhoese
Copy link
Member Author

djhoese commented Oct 13, 2023

Oh I wasn't saying the custom user products was a good thing. I just meant (without saying) that there isn't a way to add these so that they show up only in the "all" list.

What documentation do you mean? Like a NOAA/NASA guide about a product?

@graemely
Copy link

Yes, something like a NOAA/NASA guide, or a paper. Even a set of slides would be better than nothing. We can host those kinds of things on the CSPP Geo website if needed.

@djhoese
Copy link
Member Author

djhoese commented Oct 13, 2023

That might be hard for the colorized IR images as those are "it's what AWIPS does" and in some cases it sounds like TimS would prefer if we didn't follow the AWIPS default as he "lost the battle" on what colormap to be the default. I think a lot of them come down "oh this looks prettier than that one".

@graemely
Copy link

My own criteria may be close to "oh this looks prettier than that one", but I'm confident Tim has a good sciency reason for his preferences. As has been noted we can't make everyone happy, so I think the best we can do is gather input and make an informed decision. Suggest asking him why he prefers that flavor, and what documentation exists.

@djhoese
Copy link
Member Author

djhoese commented Jan 10, 2024

I think documenting and closing this issue would also qualify #286 for closing.

@djhoese djhoese modified the milestones: Geo2Grid 1.2, Geo2Grid 1.3 May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants