Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-designing of Home Page #526 #535

Closed
wants to merge 7 commits into from
Closed

Re-designing of Home Page #526 #535

wants to merge 7 commits into from

Conversation

Manishak798
Copy link

Related Issue

Closes #526

Description

I have entirely re-designed the home page and added new fonts and colors to the website that will make it look more appealing.

Screenshots

Before
image
After
image
image

Checklist

  • My code adheres to the established style guidelines of the project.
  • I have included comments in areas that may be difficult to understand.
  • My changes have not introduced any new warnings.
  • I have conducted a self-review of my code.

@Manishak798
Re-designing of Home Page #526
4158f54 
I have changed the home page entirely and added new fonts and colors that make the website look more appealing.
@Manishak798
Merge branch 'ssitvit:main' into main
eb2ae45
@netlify
Copy link

netlify bot commented Aug 4, 2023 •
edited
Loading

✅ Deploy Preview for joyful-otter-a57da4 ready!

Name Link
🔨 Latest commit c8a2c26
🔍 Latest deploy log https://app.netlify.com/sites/joyful-otter-a57da4/deploys/64d457fec9d6cb000771c98c
😎 Deploy Preview https://deploy-preview-535--joyful-otter-a57da4.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Manishak798
Copy link
Author

hey @cleveranu please check my PR.

@cleveranu
Copy link
Collaborator

Improvement needed

@cleveranu
Copy link
Collaborator

even the animation is not present in this page

@Manishak798
Copy link
Author

@cleveranu Kindly Tell me the improvements, I will do that .

@Manishak798
Copy link
Author

Hey @cleveranu as per your views on my previous work, I changed the UI accordingly added the animation, and makes it look appealing. Please check my PR.
SCREENSHOT
image

Shreyaar12
Shreyaar12 requested changes Aug 6, 2023
View reviewed changes
Copy link
Contributor

@Shreyaar12 Shreyaar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the button config and not many changes with respect to theme happening in the light/dark mode

@Manishak798
Copy link
Author

fix the button config and not many changes with respect to theme happening in the light/dark mode

Can you elaborate this a bit more

@Manishak798
Copy link
Author

Hey @Shreyaar12 I have reviewed your request as my work included redesigning the home page I did, Now in dark mode the title is not visible that is the new issue, and even if we refresh the page the enabled dark theme converts to light mode does not look appealing, Please accept my PR for designing the home page and I will raise two new issues and work upon the other this as a contributor under GSSOC my PR matters and I hope you understand that.
Thank you

@Manishak798
Copy link
Author

Hey @Shreyaar12 Please review my request.

@Manishak798
Copy link
Author

Hey @cleveranu please review my PR.

@Manishak798
Copy link
Author

Hey @Shreyaar12 please view my PR.

@Manishak798
Copy link
Author

Hey @Shreyaar12 kindly check my PR only a few days left for the GSSOC program, Kindly understand my concern.

@Manishak798
Copy link
Author

Hey @Shreyaar12 Kindly check my PR.

@Manishak798
Copy link
Author

@Shreyaar12 Kindly review my PR as tomorrow is the last day of GSSOC.

@Manishak798
Copy link
Author

Hey @cleveranu @Shreyaar12 kindly check my PR.

@Manishak798
Copy link
Author

Hey @cleveranu kindly check my PR.

@Manishak798
Copy link
Author

Hey @Shreyaar12 kindly review my PR as it's the last day of GSSOC.

@Manishak798
Copy link
Author

Hey, @cleveranu, today is the last day of GSSOC23. I urge you to review my PR as I delicately worked on it and submit it to you on time. It's already been a week now and I did not even hear back from you. I request you to please review my PR.

@Manishak798
Copy link
Author

Hey @Shreyaar12 I request you to review my PR as today is the last day of GSSOC23.

@Manishak798
Copy link
Author

Hey @Shreyaar12 Kindly check my PR.

@Manishak798
Copy link
Author

Hey, @cleveranu and @Shreyaar12 Kindly, check my PR.

@Manishak798
Copy link
Author

Hey @cleveranu kindly view my PR.

@cleveranu cleveranu added good first issue Good for newcomers gssoc23 GirlScript summer of code level2 labels Aug 10, 2023
@cleveranu cleveranu closed this Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shreyaar12 Shreyaar12 Awaiting requested review from Shreyaar12

Assignees

@Manishak798 Manishak798

Labels
good first issue Good for newcomers gssoc23 GirlScript summer of code level2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-designing of Home Page
3 participants
@Manishak798 @cleveranu @Shreyaar12