Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge case not handled properly in transformer sidecar #747

Open
ponyisi opened this issue Apr 20, 2024 · 0 comments
Open

Edge case not handled properly in transformer sidecar #747

ponyisi opened this issue Apr 20, 2024 · 0 comments

Comments

@ponyisi
Copy link
Collaborator

ponyisi commented Apr 20, 2024

Describe the bug
An UnboundLocalError can result in transformer.py of the transformer sidecar

To Reproduce
Difficult to reproduce in the wild, but one can see that in callback(), if the test on line 269 fails for whatever reason, it breaks out of the particular replica attempt without setting transformer_stats. The variable may therefore not be set when reaching the error reporting:

"error-info": transformer_stats.error_info,

Expected behavior
A more meaningful error is put in the logfile than UnboundLocalError

Additional context
Reported by Alkaid Cheng for a transformation with the python codegen. Succeeded on second attempt (presumably a transient issue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant