Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

766 replica ordering #767

Closed
wants to merge 17 commits into from
Closed

766 replica ordering #767

wants to merge 17 commits into from

Conversation

ivukotic
Copy link
Member

@ivukotic ivukotic commented May 7, 2024

fixes issue with ?files etc..
added possibility to re-sort paths in transformers.
not sending full transformation log if it was successful.
ignoring errors on reading transformer log.

@ivukotic ivukotic linked an issue May 7, 2024 that may be closed by this pull request
@BenGalewsky
Copy link
Contributor

What was the issue with ?files ? It looks like it's just been dropped entirely?

@ivukotic
Copy link
Member Author

ivukotic commented May 7, 2024

What was the issue with ?files ? It looks like it's just been dropped entirely?

all the ?files and other modifiers were written in the DB table datasets as the unique dataset name. This made it so we had a lot of different entries and a lot of lookups for the same dataset (with 65k files).
Did finder was anyhow doing the same job independently from these modifiers. This only affects what is written and read from the DB dataset table.

@ivukotic ivukotic requested a review from BenGalewsky May 7, 2024 22:58
@ivukotic
Copy link
Member Author

ivukotic commented May 9, 2024

now files=xxx works again

@ivukotic
Copy link
Member Author

It appears that there is not easy way of working around of the problem that wrong ?files=xxx implementation created.
So, I completely removed it. Now the dataset table in the database works correctly.

@ivukotic ivukotic closed this Jun 2, 2024
@ivukotic ivukotic deleted the 766-replica-ordering branch June 2, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replica ordering
2 participants