--print-timing-info does not print timing info when given a json file graph input

[researcherben]

--print-timing-info does not print timing info when given a json file graph input

Reproducer: replace foobar.py with a working architecture python file, this should act as a reproducer.

sst --output-json foobar.json foobar.py
sst --print-timing-info foobar.json

This should print the desired result.

sst --print-timing-info foobar.py

[feldergast]

That is odd behavior since the print-timing-info command line option and the model definition used to build the graph are completely independent code (or should be). I'll take a look.

[researcherben]

The bug is caused by a field in the JSON file.

sst --output-json foobar.json foobar.py --print-timing-info
sst foobar.json

causes the simulation to always print the timing info.

This should likely become a feature request to allow command line arguments to override the program options in the file.

For instance, the following

sst --output-json foobar.json foobar.py --print-timing-info
sst foobar.json --print-timing-info=0

should turn off the timing info, especially because print-timing-info takes a boolean.

[researcherben]

This issue can be re-tagged as "feature request" instead of "bug report"

[feldergast]

Command line arguments should override what’s in the input file. However, if the option only allows a one-way flag (i.e. I can only turn something on and not off), then there would be no way to turn something off on the command line that was turned on in the input file. This may mean we need to make all flags take an optional argument. Not sure if this is true today, but changing that would be pretty easy.

[feldergast]

I just checked and print-timing-info can take an argument, so setting --print-timing-info=false should override what's set in the input file. Once I have a chance to test that this works as expected I'll close the issue.

[feldergast]

Looks like the command line override of options set in the input file is broken for all options. I'll put in a fix and a test to make sure it doesn't break again.

[feldergast]

Fixed in #1017