Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve runtime performance #18

Open
imme64 opened this issue Jan 5, 2022 · 0 comments
Open

Improve runtime performance #18

imme64 opened this issue Jan 5, 2022 · 0 comments
Assignees

Comments

@imme64
Copy link
Collaborator

imme64 commented Jan 5, 2022

Running js2php in its PHP form (#14) shows around 75x slower performance compared to NodeJS version. Profiling the PHP code shows that the "get" function is called 5.6 million times and makes 28.1% of the time.
Member access could be implemented natively (without wrapper functions) and using __get(...) magic functions if the accessed property does not exist natively.
I would say that a performance factor of 20x should be possible and acceptable.

@imme64 imme64 self-assigned this Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant