From 270e03d29e3d4369c977812de5a6e731662e4cf0 Mon Sep 17 00:00:00 2001
From: Vincent Sarago <vincent.sarago@gmail.com>
Date: Mon, 1 Jul 2024 20:37:19 +0200
Subject: [PATCH] move pagination models to extensions submodule (#717)

* move pagination models to extensions submodule

* remove models from api

* update changelog

* update changelog

---------

Co-authored-by: Jonathan Healy <jonathan.d.healy@gmail.com>
---
 CHANGES.md                                    |  4 +++
 stac_fastapi/api/stac_fastapi/api/models.py   | 26 --------------
 .../extensions/core/pagination/pagination.py  |  3 +-
 .../extensions/core/pagination/request.py     | 34 +++++++++++++++++++
 .../core/pagination/token_pagination.py       |  3 +-
 5 files changed, 42 insertions(+), 28 deletions(-)
 create mode 100644 stac_fastapi/extensions/stac_fastapi/extensions/core/pagination/request.py

diff --git a/CHANGES.md b/CHANGES.md
index 2e32b5814..2b74edbb1 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -2,6 +2,10 @@
 
 ## [Unreleased] - TBD
 
+### Changed
+
+* moved `GETPagination`, `POSTPagination`, `GETTokenPagination` and `POSTTokenPagination` to `stac_fastapi.extensions.core.pagination.request` submodule [#717](https://github.com/stac-utils/stac-fastapi/pull/717)
+
 ## [3.0.0a4] - 2024-06-27
 
 ### Fixed
diff --git a/stac_fastapi/api/stac_fastapi/api/models.py b/stac_fastapi/api/stac_fastapi/api/models.py
index 2716fe7fb..307be14a7 100644
--- a/stac_fastapi/api/stac_fastapi/api/models.py
+++ b/stac_fastapi/api/stac_fastapi/api/models.py
@@ -110,32 +110,6 @@ class ItemCollectionUri(CollectionUri):
     datetime: Optional[DateTimeType] = attr.ib(default=None, converter=str_to_interval)
 
 
-class POSTTokenPagination(BaseModel):
-    """Token pagination model for POST requests."""
-
-    token: Optional[str] = None
-
-
-@attr.s
-class GETTokenPagination(APIRequest):
-    """Token pagination for GET requests."""
-
-    token: Optional[str] = attr.ib(default=None)
-
-
-class POSTPagination(BaseModel):
-    """Page based pagination for POST requests."""
-
-    page: Optional[str] = None
-
-
-@attr.s
-class GETPagination(APIRequest):
-    """Page based pagination for GET requests."""
-
-    page: Optional[str] = attr.ib(default=None)
-
-
 # Test for ORJSON and use it rather than stdlib JSON where supported
 if importlib.util.find_spec("orjson") is not None:
     from fastapi.responses import ORJSONResponse
diff --git a/stac_fastapi/extensions/stac_fastapi/extensions/core/pagination/pagination.py b/stac_fastapi/extensions/stac_fastapi/extensions/core/pagination/pagination.py
index 296e9ae6a..7959b0357 100644
--- a/stac_fastapi/extensions/stac_fastapi/extensions/core/pagination/pagination.py
+++ b/stac_fastapi/extensions/stac_fastapi/extensions/core/pagination/pagination.py
@@ -5,9 +5,10 @@
 import attr
 from fastapi import FastAPI
 
-from stac_fastapi.api.models import GETPagination, POSTPagination
 from stac_fastapi.types.extension import ApiExtension
 
+from .request import GETPagination, POSTPagination
+
 
 @attr.s
 class PaginationExtension(ApiExtension):
diff --git a/stac_fastapi/extensions/stac_fastapi/extensions/core/pagination/request.py b/stac_fastapi/extensions/stac_fastapi/extensions/core/pagination/request.py
new file mode 100644
index 000000000..9524ee324
--- /dev/null
+++ b/stac_fastapi/extensions/stac_fastapi/extensions/core/pagination/request.py
@@ -0,0 +1,34 @@
+"""Pagination extension request models."""
+
+from typing import Optional
+
+import attr
+from pydantic import BaseModel
+
+from stac_fastapi.types.search import APIRequest
+
+
+@attr.s
+class GETTokenPagination(APIRequest):
+    """Token pagination for GET requests."""
+
+    token: Optional[str] = attr.ib(default=None)
+
+
+class POSTTokenPagination(BaseModel):
+    """Token pagination model for POST requests."""
+
+    token: Optional[str] = None
+
+
+@attr.s
+class GETPagination(APIRequest):
+    """Page based pagination for GET requests."""
+
+    page: Optional[str] = attr.ib(default=None)
+
+
+class POSTPagination(BaseModel):
+    """Page based pagination for POST requests."""
+
+    page: Optional[str] = None
diff --git a/stac_fastapi/extensions/stac_fastapi/extensions/core/pagination/token_pagination.py b/stac_fastapi/extensions/stac_fastapi/extensions/core/pagination/token_pagination.py
index d3fa10391..11ccfb35b 100644
--- a/stac_fastapi/extensions/stac_fastapi/extensions/core/pagination/token_pagination.py
+++ b/stac_fastapi/extensions/stac_fastapi/extensions/core/pagination/token_pagination.py
@@ -5,9 +5,10 @@
 import attr
 from fastapi import FastAPI
 
-from stac_fastapi.api.models import GETTokenPagination, POSTTokenPagination
 from stac_fastapi.types.extension import ApiExtension
 
+from .request import GETTokenPagination, POSTTokenPagination
+
 
 @attr.s
 class TokenPaginationExtension(ApiExtension):