Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove post_request_model attribute in the BaseCoreClient and AsyncBaseCoreClient #753

Open
vincentsarago opened this issue Sep 23, 2024 · 0 comments
Open

remove post_request_model attribute in the BaseCoreClient and AsyncBaseCoreClient #753

vincentsarago opened this issue Sep 23, 2024 · 0 comments
Labels
enhancement New feature or request needs discussion

Comments

@vincentsarago
Copy link
Member

stac-fastapi/stac_fastapi/types/stac_fastapi/types/core.py

Line 344 in 753341f

post_request_model = attr.ib(default=BaseSearchPostRequest)

This attribute is not used in the abstract methods and is not event guarantee to be used in the client. We should let backend define what attribute they need

cc @hrodmn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request needs discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vincentsarago