Import python implementations from python, not rust wrapper #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadomski
requested changes
Oct 18, 2024
There was a problem hiding this comment.
Thanks for the contrib @alexgleith! Looks like there's a couple issues w/ imports and tests — I might look to tackle #462 in a separate PR, I'll be sure to cc you in.
| @@ -1,16 +1,19 @@ | |||
| from . import stacrs | |||
| from .stacrs import ( | |||
| import pystac | |||
There was a problem hiding this comment.
It was an intentional decision to not import pystac at the top level — I'd like this library to be zero-dependency by default.
There was a problem hiding this comment.
Oh, sorry, that was meant to be the internal .pystac.
There was a problem hiding this comment.
We'd want a test to confirm that this works.
|
Yeah, no worries. Sorry it's not tested, it's a pretty complex environment for me still. |
|
Closing as OBE, #468 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
Items#462Related to
Description
Fixes the main import for the init.py file by importing the Python implementations rather than the naked rust wrappers of them.
Checklist
Delete any checklist items that do not apply (e.g. if your change is minor, it may not require documentation updates).
cargo fmt)cargo test