From 58e64ad2b09abb80f90610935d311f0effa07745 Mon Sep 17 00:00:00 2001
From: Zai Shi <zaishi00@outlook.com>
Date: Sun, 8 Sep 2024 10:28:46 -0700
Subject: [PATCH] fixed otp config bug

---
 apps/backend/src/app/api/v1/users/crud.tsx | 84 ++++++++++------------
 1 file changed, 37 insertions(+), 47 deletions(-)

diff --git a/apps/backend/src/app/api/v1/users/crud.tsx b/apps/backend/src/app/api/v1/users/crud.tsx
index 751d72d4d..6f6376a31 100644
--- a/apps/backend/src/app/api/v1/users/crud.tsx
+++ b/apps/backend/src/app/api/v1/users/crud.tsx
@@ -232,11 +232,8 @@ async function getPasswordConfig(tx: PrismaTransaction, projectConfigId: string)
   if (passwordConfig.length > 1) {
     throw new StackAssertionError("Multiple password auth methods found in the project", passwordConfig);
   }
-  if (passwordConfig.length === 0) {
-    throw new StatusError(StatusError.BadRequest, "Password auth not enabled in the project");
-  }
 
-  return passwordConfig[0];
+  return passwordConfig.length === 0 ? null : passwordConfig[0];
 }
 
 // TODO: retrieve in the project
@@ -253,11 +250,8 @@ async function getOtpConfig(tx: PrismaTransaction, projectConfigId: string) {
   if (otpConfig.length > 1) {
     throw new StackAssertionError("Multiple OTP auth methods found in the project", otpConfig);
   }
-  if (otpConfig.length === 0) {
-    throw new StatusError(StatusError.BadRequest, "OTP auth not enabled in the project");
-  }
 
-  return otpConfig[0];
+  return otpConfig.length === 0 ? null : otpConfig[0];
 }
 
 export const getUserLastActiveAtMillis = async (userId: string, fallbackTo: number | Date): Promise<number> => {
@@ -458,41 +452,31 @@ export const usersCrudHandlers = createLazyProxy(() => createCrudHandlers(usersC
         if (data.primary_email_auth_enabled) {
           const otpConfig = await getOtpConfig(tx, auth.project.config.id);
 
-          await tx.authMethod.create({
-            data: {
-              projectId: auth.project.id,
-              projectUserId: newUser.projectUserId,
-              projectConfigId: auth.project.config.id,
-              authMethodConfigId: otpConfig.authMethodConfigId,
-              otpAuthMethod: {
-                create: {
-                  projectUserId: newUser.projectUserId,
-                  contactChannelId: contactChannel.id,
+          if (otpConfig) {
+            await tx.authMethod.create({
+              data: {
+                projectId: auth.project.id,
+                projectUserId: newUser.projectUserId,
+                projectConfigId: auth.project.config.id,
+                authMethodConfigId: otpConfig.authMethodConfigId,
+                otpAuthMethod: {
+                  create: {
+                    projectUserId: newUser.projectUserId,
+                    contactChannelId: contactChannel.id,
+                  }
                 }
               }
-            }
-          });
-        }
-
-        const passwordConfig = await tx.passwordAuthMethodConfig.findMany({
-          where: {
-            projectConfigId: auth.project.config.id,
-          },
-          include: {
-            authMethodConfig: true,
+            });
           }
-        });
-
-        if (passwordConfig.length === 0) {
-          throw new StatusError(StatusError.BadRequest, "Password auth not enabled in the project");
-        }
-        if (passwordConfig.length > 1) {
-          throw new StackAssertionError("Multiple password auth methods found in the project", passwordConfig);
         }
 
         if (data.password) {
           const passwordConfig = await getPasswordConfig(tx, auth.project.config.id);
 
+          if (!passwordConfig) {
+            throw new StatusError(StatusError.BadRequest, "Password auth not enabled in the project");
+          }
+
           await tx.authMethod.create({
             data: {
               projectId: auth.project.id,
@@ -730,20 +714,22 @@ export const usersCrudHandlers = createLazyProxy(() => createCrudHandlers(usersC
 
             const otpConfig = await getOtpConfig(tx, auth.project.config.id);
 
-            await tx.authMethod.create({
-              data: {
-                projectId: auth.project.id,
-                projectConfigId: auth.project.config.id,
-                projectUserId: params.user_id,
-                authMethodConfigId: otpConfig.authMethodConfigId,
-                otpAuthMethod: {
-                  create: {
-                    projectUserId: params.user_id,
-                    contactChannelId: primaryEmailChannel.id,
+            if (otpConfig) {
+              await tx.authMethod.create({
+                data: {
+                  projectId: auth.project.id,
+                  projectConfigId: auth.project.config.id,
+                  projectUserId: params.user_id,
+                  authMethodConfigId: otpConfig.authMethodConfigId,
+                  otpAuthMethod: {
+                    create: {
+                      projectUserId: params.user_id,
+                      contactChannelId: primaryEmailChannel.id,
+                    }
                   }
                 }
-              }
-            });
+              });
+            }
           }
         } else {
           if (otpAuth) {
@@ -804,6 +790,10 @@ export const usersCrudHandlers = createLazyProxy(() => createCrudHandlers(usersC
 
             const passwordConfig = await getPasswordConfig(tx, auth.project.config.id);
 
+            if (!passwordConfig) {
+              throw new StatusError(StatusError.BadRequest, "Password auth not enabled in the project");
+            }
+
             await tx.authMethod.create({
               data: {
                 projectId: auth.project.id,