fix: linting

Author: dervoeti

backend/application/commons/migrations/0020_merge_20251010_1716.py

@@ -0,0 +1,13 @@
+# Generated by Django 5.2.7 on 2025-10-10 15:16
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("commons", "0018_settings_vex_justification_style_and_more"),
+        ("commons", "0019_merge_20250727_1457"),
+    ]
+
+    operations = []

backend/application/core/migrations/0076_merge_20251010_1715.py

@@ -0,0 +1,13 @@
+# Generated by Django 5.2.7 on 2025-10-10 15:15
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("core", "0070_components_view_open_observations"),
+        ("core", "0075_merge_20250715_1104"),
+    ]
+
+    operations = []

backend/application/rules/migrations/0018_merge_20251010_1715.py

@@ -0,0 +1,13 @@
+# Generated by Django 5.2.7 on 2025-10-10 15:15
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("rules", "0016_alter_rule_new_vex_justification"),
+        ("rules", "0017_alter_rule_approval_remark"),
+    ]
+
+    operations = []

frontend/src/commons/functions.tsx

@@ -358,8 +358,10 @@ export const justificationIsEnabledForStatus = (status: string) => {
 
 export const remediationsAreEnabledForStatus = (status: string) => {
     const vex_enabled = feature_vex_enabled();
-    const remediations_recommended_for_status =
-        [OBSERVATION_STATUS_RISK_ACCEPTED, OBSERVATION_STATUS_AFFECTED].indexOf(status) >= 0;
+    const remediations_recommended_for_status = [
+        OBSERVATION_STATUS_RISK_ACCEPTED,
+        OBSERVATION_STATUS_AFFECTED,
+    ].includes(status);
     return vex_enabled && remediations_recommended_for_status;
 };
 export const is_superuser = () => {

frontend/src/core/observations/ObservationAssessment.tsx

@@ -15,7 +15,11 @@ import {
 import SmallButton from "../../commons/custom_fields/SmallButton";
 import { ToolbarCancelSave } from "../../commons/custom_fields/ToolbarCancelSave";
 import { validate_after_today, validate_required } from "../../commons/custom_validators";
-import { justificationIsEnabledForStatus, remediationsAreEnabledForStatus, settings_vex_justification_style } from "../../commons/functions";
+import {
+    justificationIsEnabledForStatus,
+    remediationsAreEnabledForStatus,
+    settings_vex_justification_style,
+} from "../../commons/functions";
 import { AutocompleteInputMedium, AutocompleteInputWide, TextInputWide } from "../../commons/layout/themes";
 import { httpClient } from "../../commons/ra-data-django-rest-framework";
 import { VEX_JUSTIFICATION_TYPE_CSAF_OPENVEX, VEX_JUSTIFICATION_TYPE_CYCLONEDX } from "../../commons/types";

frontend/src/core/observations/ObservationBulkAssessment.tsx

@@ -22,7 +22,7 @@ import {
     settings_risk_acceptance_expiry_date,
     settings_vex_justification_style,
 } from "../../commons/functions";
-import { AutocompleteInputMedium, TextInputWide, AutocompleteInputWide } from "../../commons/layout/themes";
+import { AutocompleteInputMedium, AutocompleteInputWide, TextInputWide } from "../../commons/layout/themes";
 import { httpClient } from "../../commons/ra-data-django-rest-framework";
 import { VEX_JUSTIFICATION_TYPE_CSAF_OPENVEX, VEX_JUSTIFICATION_TYPE_CYCLONEDX } from "../../commons/types";
 import {

frontend/src/core/observations/ObservationEmbeddedList.tsx

@@ -218,9 +218,9 @@ const ObservationsEmbeddedList = ({ product }: ObservationsEmbeddedListProps) =>
                         <SeverityField label="Severity" source="current_severity" />
                         <ChipField source="current_status" label="Status" />
                         <NumberField source="upgrade_impact_score" label="Upgrade Impact Score" />
-                        {product && product.has_component && <NumberField source="epss_score" label="EPSS" />}
+                        {product?.has_component && <NumberField source="epss_score" label="EPSS" />}
                         {/* {product && product.has_services && <TextField source="origin_service_name" label="Service" />} */}
-                        {product && product.has_component && (
+                        {product?.has_component && (
                             <TextField
                                 source="origin_component_name_version"
                                 label="Component"

frontend/src/core/observations/ObservationShowDescriptionRecommendation.tsx

@@ -18,10 +18,10 @@ const ObservationShowDescriptionRecommendation = () => {
                     <MarkdownField content={observation.recommendation} label="Recommendation" />
                 </Labeled>
             )}
-            {observation && observation.duplicates && observation.duplicates.length > 0 && (
+            {observation?.duplicates?.length > 0 && (
                 <Labeled label="Duplicates">
                     <Stack direction="row" spacing={2}>
-                        {observation.duplicates.map((duplicate: any) => (
+                        {observation!.duplicates.map((duplicate: any) => (
                             <TextUrlField
                                 label="Duplicate"
                                 text={duplicate.id}

frontend/src/rules/functions.tsx

@@ -29,12 +29,11 @@ import {
     settings_vex_justification_style,
 } from "../commons/functions";
 import { AutocompleteInputMedium, AutocompleteInputWide, TextInputWide, useStyles } from "../commons/layout/themes";
-import { VEX_JUSTIFICATION_TYPE_CSAF_OPENVEX, VEX_JUSTIFICATION_TYPE_CYCLONEDX } from "../commons/types";
+import { VEX_JUSTIFICATION_TYPE_CYCLONEDX } from "../commons/types";
 import {
     OBSERVATION_CYCLONEDX_VEX_JUSTIFICATION_CHOICES,
     OBSERVATION_SEVERITY_CHOICES,
     OBSERVATION_STATUS_CHOICES,
-    OBSERVATION_VEX_JUSTIFICATION_CHOICES,
     OBSERVATION_VEX_REMEDIATION_CATEGORY_CHOICES,
 } from "../core/types";
 import general_rules from "./general_rules";