Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Check if druid.client.https.validateHostnames can be turned of #372

Open
sbernauer opened this issue Jan 9, 2023 · 3 comments

Comments

@sbernauer
Copy link
Member

Affected version

nightly

Current and expected behavior

Currently we set druid.client.https.validateHostnames and druid.server.https.validateHostnames to false which imposes a security risk.
We should get rid of it.
Context:

// This is required because the server will send its pod ip which is not in the SANs of the certificates
// TODO TEST TEST TEST!
// Awful!
config.insert(
Self::CLIENT_HTTPS_VALIDATE_HOST_NAMES.to_string(),
Some("false".to_string()),
);

Possible solution

No idea, needs testing

Additional context

No response

Environment

No response

Would you like to work on fixing this bug?

None

@maltesander
Copy link
Member

We only know the Pod IP after the Pod has been created and the secrets are mounted already.

I do not see a "smart" workaround for this in the foreseeable future.

@sbernauer
Copy link
Member Author

Maybe we can get the services to talk to each other via DNS names ;)

@lfrancke
Copy link
Member

If only we had a solution for that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants