Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add helper function SecretOperatorVolumeSourceBuilder::with_kerberos_service_name #568

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Add helper function SecretOperatorVolumeSourceBuilder::with_kerberos_service_name #568

wants to merge 3 commits into from

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Mar 15, 2023 •
edited
Loading

Description

Needed for stackabletech/hdfs-operator#334 and stackabletech/hdfs-operator#178

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer sbernauer changed the title Add helper function Add helper function SecretOperatorVolumeSourceBuilder::with_kerberos_service_name Mar 16, 2023
@sbernauer sbernauer changed the title Add helper function SecretOperatorVolumeSourceBuilder::with_kerberos_service_name Add helper function SecretOperatorVolumeSourceBuilder::with_kerberos_service_name Mar 16, 2023
@sbernauer sbernauer marked this pull request as ready for review March 16, 2023 12:12
@sbernauer sbernauer requested a review from nightkr March 16, 2023 12:14
@sbernauer sbernauer self-assigned this Mar 16, 2023
nightkr
nightkr approved these changes Mar 17, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@sbernauer @nightkr
Update CHANGELOG.md
fb1b3f3 
Co-authored-by: Natalie <[email protected]>
@sbernauer
Copy link
Member Author

Thx!

@sbernauer
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Mar 17, 2023
@sbernauer
Add helper function SecretOperatorVolumeSourceBuilder::with_kerberos_…
0045c90 
…service_name (#568)

## Description

Needed for stackabletech/hdfs-operator#334 and stackabletech/hdfs-operator#178
@bors
Copy link
Contributor

bors bot commented Mar 17, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add helper function SecretOperatorVolumeSourceBuilder::with_kerberos_service_name [Merged by Bors] - Add helper function SecretOperatorVolumeSourceBuilder::with_kerberos_service_name Mar 17, 2023
@bors bors bot closed this Mar 17, 2023
@bors bors bot deleted the feat/kerberos-secret-class-helpers branch March 17, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nightkr nightkr nightkr approved these changes

Assignees

@sbernauer sbernauer

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbernauer @nightkr