Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display images #309

Open
eric-burel opened this issue Sep 3, 2024 · 0 comments · May be fixed by #328
Open

Display images #309

eric-burel opened this issue Sep 3, 2024 · 0 comments · May be fixed by #328
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@eric-burel
Copy link
Contributor

eric-burel commented Sep 3, 2024

Is your feature request related to a problem?

Codemirror editor doesn't seem to support images
image

Describe the solution you'd like.

Display images within the code editor

Describe alternatives you've considered.

This behaviour is implemented in the react package CodeMirrorEditor: "packages/react/src/core/CodeMirrorEditor/BinaryContent.tsx" which is triggered there:
"packages/react/src/core/CodeMirrorEditor/index.tsx"

Additional context

I think this is a good first issue:

  • we can detect images via mime-type
  • and then display them
    Would a PR creating a new "ImageContent" component be accepted? Does display images create any sort of security risk?
@Nemikolh Nemikolh added enhancement New feature or request good first issue Good for newcomers labels Sep 3, 2024
@eric-burel eric-burel linked a pull request Sep 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants