Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toggle terminal visibility #363

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SeanHersh
Copy link

Description of What Happened:
In my open-source contribution, I aimed to fix a bug where the "Toggle Terminal" button stayed visible even when the terminal was set to be hidden in the metadata. After investigating, I realized that key parts of the metadata handling function were missing from the repository I pulled from.

I added a terminal property to the part schema as a boolean flag to address this. This flag controls whether the terminal should be shown or hidden for each tutorial part. While I couldn't fully verify the solution due to missing parts in the repository, I contributed this schema change as a potential fix to help manage terminal visibility.

Additions Made:

Added terminal property to the part schema to control terminal visibility for each part.
Introduced logic based on this flag to toggle the terminal visibility in the interface.

All added components have been commented out with a full description of functionality and purpose

Copy link

stackblitz bot commented Oct 3, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @SeanHersh!

However these changes don't look right to me. This bug fix should not require any changes in how metadata is configured. We'll also need test cases that verify the fix in order to accept PRs for this.

It also seems that this issue might already be working just fine: #300 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants