Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All images display:block #2

Open
rreusser opened this issue Aug 11, 2015 · 3 comments
Open

All images display:block #2

rreusser opened this issue Aug 11, 2015 · 3 comments

Comments

@rreusser
Copy link
Member

Makes it impossible to use inline images, and since this css is imported via js, makes it tricky also to override. Need to investigate further. See: index.css#L166

@rreusser
Copy link
Member Author

rreusser commented Jan 5, 2016

Haha, tracked down my bug and finally ended up right back here. I end up with readme content that looks like this:

screen shot 2016-01-05 at 10 06 45 am

Can this css simply be removed? It looks like github simply leaves that unset and so all images pick up display: inline from the user agent stylesheet. I believe it accomplishes block images by wrapping them in a p tag (i.e. they're on their own line), which should happen automatically.

I'll submit a PR and can discuss further from there.

@rreusser
Copy link
Member Author

rreusser commented Jan 5, 2016

(Note: wording of that sentence in my image is an entirely separate but equally serious issue 😬)

rreusser added a commit to scijs/scijs-readme-css that referenced this issue Jan 6, 2016
@rreusser
Copy link
Member Author

rreusser commented Jan 6, 2016

Fixed by forking stackgl-readme-css. Just pointing it to the github repo at the moment. I haven't decided whether it's a good idea to maintain a separate fork of this. Leaving the issue open until it's clear whether these changes (tables too, once I get to that) should be merged or just left forked.

See, e.g.: http://scijs.net/packages/#scijs/ndarray-band

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant