Skip to content

Commit 64d6fa9

Browse files
authored
feat(resourcemanager): graduate folder resource to ga (#1043)
1 parent a81b7d4 commit 64d6fa9

File tree

6 files changed

+8
-51
lines changed

6 files changed

+8
-51
lines changed

docs/data-sources/resourcemanager_folder.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,12 @@ page_title: "stackit_resourcemanager_folder Data Source - stackit"
44
subcategory: ""
55
description: |-
66
Resource Manager folder data source schema. To identify the folder, you need to provide the container_id.
7-
~> This datasource is in beta and may be subject to breaking changes in the future. Use with caution. See our guide https://registry.terraform.io/providers/stackitcloud/stackit/latest/docs/guides/opting_into_beta_resources for how to opt-in to use beta resources.
87
---
98

109
# stackit_resourcemanager_folder (Data Source)
1110

1211
Resource Manager folder data source schema. To identify the folder, you need to provide the container_id.
1312

14-
~> This datasource is in beta and may be subject to breaking changes in the future. Use with caution. See our [guide](https://registry.terraform.io/providers/stackitcloud/stackit/latest/docs/guides/opting_into_beta_resources) for how to opt-in to use beta resources.
15-
1613
## Example Usage
1714

1815
```terraform

docs/resources/resourcemanager_folder.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,12 @@ page_title: "stackit_resourcemanager_folder Resource - stackit"
44
subcategory: ""
55
description: |-
66
Resource Manager folder resource schema.
7-
~> This resource is in beta and may be subject to breaking changes in the future. Use with caution. See our guide https://registry.terraform.io/providers/stackitcloud/stackit/latest/docs/guides/opting_into_beta_resources for how to opt-in to use beta resources.
87
---
98

109
# stackit_resourcemanager_folder (Resource)
1110

1211
Resource Manager folder resource schema.
1312

14-
~> This resource is in beta and may be subject to breaking changes in the future. Use with caution. See our [guide](https://registry.terraform.io/providers/stackitcloud/stackit/latest/docs/guides/opting_into_beta_resources) for how to opt-in to use beta resources.
15-
1613
## Example Usage
1714

1815
```terraform

stackit/internal/services/resourcemanager/folder/datasource.go

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ import (
1616
"github.com/stackitcloud/stackit-sdk-go/services/resourcemanager"
1717
"github.com/stackitcloud/terraform-provider-stackit/stackit/internal/conversion"
1818
"github.com/stackitcloud/terraform-provider-stackit/stackit/internal/core"
19-
"github.com/stackitcloud/terraform-provider-stackit/stackit/internal/features"
2019
resourcemanagerUtils "github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/resourcemanager/utils"
2120
"github.com/stackitcloud/terraform-provider-stackit/stackit/internal/utils"
2221
"github.com/stackitcloud/terraform-provider-stackit/stackit/internal/validate"
@@ -49,11 +48,6 @@ func (d *folderDataSource) Configure(ctx context.Context, req datasource.Configu
4948
return
5049
}
5150

52-
features.CheckBetaResourcesEnabled(ctx, &providerData, &resp.Diagnostics, "stackit_resourcemanager_folder", "datasource")
53-
if resp.Diagnostics.HasError() {
54-
return
55-
}
56-
5751
apiClient := resourcemanagerUtils.ConfigureClient(ctx, &providerData, &resp.Diagnostics)
5852
if resp.Diagnostics.HasError() {
5953
return
@@ -78,7 +72,7 @@ func (d *folderDataSource) Schema(_ context.Context, _ datasource.SchemaRequest,
7872
}
7973

8074
resp.Schema = schema.Schema{
81-
Description: features.AddBetaDescription(descriptions["main"], core.Datasource),
75+
Description: descriptions["main"],
8276
Attributes: map[string]schema.Attribute{
8377
"id": schema.StringAttribute{
8478
Description: descriptions["id"],

stackit/internal/services/resourcemanager/folder/resource.go

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ import (
2727
"github.com/stackitcloud/stackit-sdk-go/services/resourcemanager"
2828
"github.com/stackitcloud/terraform-provider-stackit/stackit/internal/conversion"
2929
"github.com/stackitcloud/terraform-provider-stackit/stackit/internal/core"
30-
"github.com/stackitcloud/terraform-provider-stackit/stackit/internal/features"
3130
resourcemanagerUtils "github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/resourcemanager/utils"
3231
"github.com/stackitcloud/terraform-provider-stackit/stackit/internal/validate"
3332
)
@@ -81,11 +80,6 @@ func (r *folderResource) Configure(ctx context.Context, req resource.ConfigureRe
8180
return
8281
}
8382

84-
features.CheckBetaResourcesEnabled(ctx, &providerData, &resp.Diagnostics, "stackit_resourcemanager_folder", "resource")
85-
if resp.Diagnostics.HasError() {
86-
return
87-
}
88-
8983
apiClient := resourcemanagerUtils.ConfigureClient(ctx, &providerData, &resp.Diagnostics)
9084
if resp.Diagnostics.HasError() {
9185
return
@@ -110,7 +104,7 @@ func (r *folderResource) Schema(_ context.Context, _ resource.SchemaRequest, res
110104
}
111105

112106
resp.Schema = schema.Schema{
113-
Description: features.AddBetaDescription(descriptions["main"], core.Resource),
107+
Description: descriptions["main"],
114108
Attributes: map[string]schema.Attribute{
115109
"id": schema.StringAttribute{
116110
Description: descriptions["id"],

stackit/internal/services/resourcemanager/resourcemanager_acc_test.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ func TestAccResourceManagerFolderContainerId(t *testing.T) {
273273
// Create
274274
{
275275
ConfigVariables: testConfigResourceFolderParentContainerId,
276-
Config: testutil.ResourceManagerProviderConfigBetaEnabled() + resourceFolder,
276+
Config: testutil.ResourceManagerProviderConfig() + resourceFolder,
277277
Check: resource.ComposeAggregateTestCheckFunc(
278278
resource.TestCheckResourceAttr("stackit_resourcemanager_folder.example", "name", testutil.ConvertConfigVariable(testConfigResourceFolderParentContainerId["name"])),
279279
resource.TestCheckResourceAttr("stackit_resourcemanager_folder.example", "parent_container_id", testutil.ConvertConfigVariable(testConfigResourceFolderParentContainerId["parent_container_id"])),
@@ -297,7 +297,7 @@ func TestAccResourceManagerFolderContainerId(t *testing.T) {
297297
data "stackit_resourcemanager_folder" "example" {
298298
container_id = stackit_resourcemanager_folder.example.container_id
299299
}
300-
`, testutil.ResourceManagerProviderConfigBetaEnabled(), resourceFolder),
300+
`, testutil.ResourceManagerProviderConfig(), resourceFolder),
301301
Check: resource.ComposeAggregateTestCheckFunc(
302302
resource.TestCheckResourceAttr("data.stackit_resourcemanager_folder.example", "name", testutil.ConvertConfigVariable(testConfigResourceFolderParentContainerId["name"])),
303303
resource.TestCheckResourceAttr("data.stackit_resourcemanager_folder.example", "labels.%", "1"),
@@ -324,7 +324,7 @@ func TestAccResourceManagerFolderContainerId(t *testing.T) {
324324
// Update
325325
{
326326
ConfigVariables: testConfigFolderNameParentContainerIdUpdated(),
327-
Config: testutil.ResourceManagerProviderConfigBetaEnabled() + resourceFolder,
327+
Config: testutil.ResourceManagerProviderConfig() + resourceFolder,
328328
Check: resource.ComposeAggregateTestCheckFunc(
329329
resource.TestCheckResourceAttr("stackit_resourcemanager_folder.example", "name", testutil.ConvertConfigVariable(testConfigFolderNameParentContainerIdUpdated()["name"])),
330330
resource.TestCheckResourceAttr("stackit_resourcemanager_folder.example", "parent_container_id", testutil.ConvertConfigVariable(testConfigFolderNameParentContainerIdUpdated()["parent_container_id"])),
@@ -352,7 +352,7 @@ func TestAccResourceManagerFolderParentUUID(t *testing.T) {
352352
// Create
353353
{
354354
ConfigVariables: testConfigResourceFolderParentUUID,
355-
Config: testutil.ResourceManagerProviderConfigBetaEnabled() + resourceFolder,
355+
Config: testutil.ResourceManagerProviderConfig() + resourceFolder,
356356
Check: resource.ComposeAggregateTestCheckFunc(
357357
resource.TestCheckResourceAttr("stackit_resourcemanager_folder.example", "name", testutil.ConvertConfigVariable(testConfigResourceFolderParentUUID["name"])),
358358
resource.TestCheckResourceAttr("stackit_resourcemanager_folder.example", "parent_container_id", testutil.ConvertConfigVariable(testConfigResourceFolderParentUUID["parent_container_id"])),
@@ -376,7 +376,7 @@ func TestAccResourceManagerFolderParentUUID(t *testing.T) {
376376
data "stackit_resourcemanager_folder" "example" {
377377
container_id = stackit_resourcemanager_folder.example.container_id
378378
}
379-
`, testutil.ResourceManagerProviderConfigBetaEnabled(), resourceFolder),
379+
`, testutil.ResourceManagerProviderConfig(), resourceFolder),
380380
Check: resource.ComposeAggregateTestCheckFunc(
381381
resource.TestCheckResourceAttr("data.stackit_resourcemanager_folder.example", "name", testutil.ConvertConfigVariable(testConfigResourceFolderParentUUID["name"])),
382382
resource.TestCheckResourceAttr("data.stackit_resourcemanager_folder.example", "labels.%", "1"),
@@ -403,7 +403,7 @@ func TestAccResourceManagerFolderParentUUID(t *testing.T) {
403403
// Update
404404
{
405405
ConfigVariables: testConfigFolderNameParentUUIDUpdated(),
406-
Config: testutil.ResourceManagerProviderConfigBetaEnabled() + resourceFolder,
406+
Config: testutil.ResourceManagerProviderConfig() + resourceFolder,
407407
Check: resource.ComposeAggregateTestCheckFunc(
408408
resource.TestCheckResourceAttr("stackit_resourcemanager_folder.example", "name", testutil.ConvertConfigVariable(testConfigFolderNameParentUUIDUpdated()["name"])),
409409
resource.TestCheckResourceAttr("stackit_resourcemanager_folder.example", "parent_container_id", testutil.ConvertConfigVariable(testConfigFolderNameParentUUIDUpdated()["parent_container_id"])),

stackit/internal/testutil/testutil.go

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -342,31 +342,6 @@ func ResourceManagerProviderConfig() string {
342342
)
343343
}
344344

345-
func ResourceManagerProviderConfigBetaEnabled() string {
346-
token := GetTestProjectServiceAccountToken("")
347-
if ResourceManagerCustomEndpoint == "" || AuthorizationCustomEndpoint == "" {
348-
return fmt.Sprintf(`
349-
provider "stackit" {
350-
service_account_token = "%s"
351-
enable_beta_resources = true
352-
}`,
353-
354-
token,
355-
)
356-
}
357-
return fmt.Sprintf(`
358-
provider "stackit" {
359-
resourcemanager_custom_endpoint = "%s"
360-
authorization_custom_endpoint = "%s"
361-
service_account_token = "%s"
362-
enable_beta_resources = true
363-
}`,
364-
ResourceManagerCustomEndpoint,
365-
AuthorizationCustomEndpoint,
366-
token,
367-
)
368-
}
369-
370345
func SecretsManagerProviderConfig() string {
371346
if SecretsManagerCustomEndpoint == "" {
372347
return `

0 commit comments

Comments
 (0)