Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad OSV PR suggestions #4452

Open
evankanderson opened this issue Sep 11, 2024 · 0 comments
Open

Bad OSV PR suggestions #4452

evankanderson opened this issue Sep 11, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@evankanderson
Copy link
Member

Describe the issue

https://github.com/stacklok/minder/pull/4440/files/690fa2df0b83a36857618fdeca86f897b2821e9c#r1753513887

-       "version": "0.18.0",
-       "resolved": "https://registry.npmjs.org/send/-/send-0.18.0.tgz",
-       "integrity": "sha512-qqWzuOjSFOuqPjFe4NOsMLafToQQwBSOEpS+FwEt3A2V3vKubTquT3vmLTQpFgMXp8AlFWFuP1qKaJZOtPpVXg==",
-       "dependencies": {
-         "debug": "2.6.9",
-         "depd": "2.0.0",
+     "node_modules/serve-static/node_modules/send": {
+       "version": "0.18.0",
+ 0.18.0
+       "version": "0.19.0",
+       "resolved": "https://registry.npmjs.org/send/-/send-0.19.0.tgz",
+       "integrity": "sha512-dW41u5VfLXu8SJh5bwRmyYUbAoSB3c9uQh6L8h/KtsFREPWpbX1lrljJo186Jc4nmci/sGUZ9a0a0J2zgfq2hw==",

This diff is nonsense -- it's not even valid JSON! Meanwhile, the original PR actually did upgrade node_modules/send to 0.19.0; this was a sub-module dependency of serve-static which got picked up.

To Reproduce

See above

What version are you using?

No response

@evankanderson evankanderson added the bug Something isn't working label Sep 11, 2024
@evankanderson evankanderson self-assigned this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant