Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add template support to evaluation details. #4532

Merged
merged 1 commit into from
Sep 20, 2024

Commits on Sep 20, 2024

  1. Add template support to evaluation details.

    This change extends error type available for use in evaluation engines
    with support for go templates. This error type supports rendering
    complex templates along with the usual string rendering. Despite the
    type itself being the same, a new constructor was added to avoid a
    bigger refactoring. Ideally, the old constructor should be deprecated
    and all places returning an `ErrEvaluationFailed` error should use the
    new one instead.
    
    Templates are internal to Minder and cannot be customized by the end
    user. Also, template engine choice was arbitrary and can be changed at
    any time.
    
    Fixes #4525
    Fixes #4526
    blkt committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    68bd32a View commit details
    Browse the repository at this point in the history