Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native multiarch image builds #1593

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Native multiarch image builds #1593

wants to merge 5 commits into from

Conversation

Molter73
Copy link
Collaborator

@Molter73 Molter73 commented Mar 8, 2024 •
edited
Loading

Description

Rework de builder image workflow in a way similar to the slim image build on #1585. Move multiarch image builds so they are built as fast as possible. After some testing, most multiarch images are substantially faster on remote VMs, except for the slim image for ppc64le, which takes longer than building on GHA due to it taking a long time to provision.

There's a couple potential follow ups to this PR:

  • Improve ppc64le VMs provisioning times.
  • Unify builder and slim image builds so VMs can be reused when both images are needed to be built. This can be achieved by either moving more logic into ansible or brute forcing GHA.

Checklist

  • Investigated and inspected CI test results

Testing Performed

  • Run with no labels. (CI run)
  • Run with the build-builder-image label. (CI run)
  • Run with the run-multiarch-builds label. (CI run)
  • Run with both the build-builder-image and run-multiarch-builds labels. (CI run)

@Molter73 Molter73 force-pushed the mauro/native-ppc64le-image-builds branch from 3f60648 to d3be1cd Compare March 8, 2024 12:04
@Molter73 Molter73 changed the title Native ppc64le image builds Native multiarch image builds Mar 14, 2024
@Molter73 Molter73 force-pushed the mauro/native-ppc64le-image-builds branch from 1fbea0b to fba6f21 Compare March 14, 2024 13:34
Base automatically changed from mauro/ci-split-slim-builds to master March 14, 2024 15:33
@Molter73 Molter73 force-pushed the mauro/native-ppc64le-image-builds branch 5 times, most recently from 6e1e3c5 to 3e425ff Compare March 15, 2024 08:05
@Molter73 Molter73 force-pushed the mauro/native-ppc64le-image-builds branch from 95dd7ce to 0b5ef40 Compare March 15, 2024 11:16
@Molter73 Molter73 added build-builder-image run-multiarch-builds Run steps for non-x86 archs. and removed run-multiarch-builds Run steps for non-x86 archs. labels Mar 15, 2024
@Molter73 Molter73 marked this pull request as ready for review March 15, 2024 16:18
@Molter73 Molter73 requested a review from a team as a code owner March 15, 2024 16:18
@Molter73
Build power images on remote VMs
094b541 
Try building power images on a remote VM

Testing

Clone repo on power builder

Stop creating all VMs

Minor simplification
@Molter73
Split remote and local builder image builds
462001b 
Always cleanup build VMs
@Molter73
Move Arm build to remote VMs
e3b1fb1 
Try moving arm build to remote VMs too

Refresh inventory after creating build VMs

Fix disable_profiling variable

Remove unneeded env definition

Add missing condition to slim image builds on GHA

Simplify builder tag definition a bit

Minor fix
@Molter73
Use fastest combinations
a7eb5be 
- amd64: locally
- arm64: remote VM
- s390x: remote VM
- ppc64le: builder on remote, collector image locally
@Molter73
Use full ref for cloning
6d195db
@Molter73 Molter73 force-pushed the mauro/native-ppc64le-image-builds branch from c336036 to 6d195db Compare March 15, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build-builder-image run-multiarch-builds Run steps for non-x86 archs. skip-integration-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Molter73