fix: remove duktape from civetweb to remove debugger #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SAST scan showed the duktape dubugger as exploitable (https://cov01.lab.eng.brq2.redhat.com/osh/task/747071/log/rhacs-collector-container-4.6.0-1/scan-results-imp.html previous version ignored manually: https://gitlab.cee.redhat.com/osh/known-false-positives/-/blob/master/rhacs-collector-container/ignore.err?ref_type=heads). Can we remove duktape from the civetweb collector uses? (expecting CI tests to fail if collector relies on the embeeded duktape js engine). Then if it is not found in the scan, we will not need to keep ignoring it after civetweb version updates.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.
For more details, ref the Confluence page about this section.