Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure shortcircuiting function body with runtime errors does not introduce issues #512

Open
matteojug opened this issue Sep 16, 2024 · 0 comments

Comments

@matteojug
Copy link
Contributor

matteojug commented Sep 16, 2024

When throwing runtime errors for reused argument in function definition, we are replacing the function body instructions with the runtime error call. We traverse the body expression to check the body is valid, in case there are errors that the typechecker alone cannot catch; we don't have examples of such instances, we do that to play it safe.

We need to double check that this is not creating dangling references or other unexpected behaviours (or ensure that the leaking side effects are not problematic).

Originally posted by @matteojug in #510 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Status: 🆕 New
Development

No branches or pull requests

2 participants