Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Withdrawal payloads should not be replayable #31

Open
netrome opened this issue Aug 1, 2023 · 2 comments
Open

Withdrawal payloads should not be replayable #31

netrome opened this issue Aug 1, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request stale

Comments

@netrome
Copy link
Contributor

netrome commented Aug 1, 2023

In the current design, anyone could replay a withdrawal request and cause the protocol to withdraw someone else's sBTC. We should not allow this.

Definition of done

The protocol has been updated so that withdrawal payloads are not replayable.

@netrome
Copy link
Contributor Author

netrome commented Aug 31, 2023

A simple solution to this would be to sign the the txid of the first input to the sBTC transaction in addition to the amount and recipient scriptPubKey in the withdrawal data.

Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
Status: Status: 🆕 New
Development

No branches or pull requests

2 participants