Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing in-place request-id checks in sbtc-registry on non-mainnet #895

Open
BowTiedRadone opened this issue Nov 19, 2024 · 0 comments
Open

Comments

@BowTiedRadone
Copy link

The sbtc-registry contract has a subtle issue in its complete-withdrawal-accept and complete-withdrawal-reject functions: neither includes a request-id check. While this isn’t a problem on mainnet — validate-protocol-caller ensures these functions are gated — it’s less clear on other networks. On non-mainnet environments, the contract deployer could influence the flow and allow a request-id greater than last-withdrawal-request-id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant