Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stacks.js and use estimateTransaction #12

Open
diwakergupta opened this issue Jan 21, 2022 · 1 comment · May be fixed by #13
Open

Update stacks.js and use estimateTransaction #12

diwakergupta opened this issue Jan 21, 2022 · 1 comment · May be fixed by #13
Assignees
@MarvinJanssen

Comments

@diwakergupta
Copy link
Member

The current implementation uses estimateFee which is deprecated in favor of estimateTransaction. Switching to latter would provide better fee estimates for send-many transactions.

(see https://github.com/hirosystems/stacks.js/blob/fe831cf28d71de9410c81cfabe256fd511e9aa4d/packages/transactions/src/builders.ts#L176)
@wileyj
Copy link

wileyj commented Feb 10, 2022

@MarvinJanssen

@MarvinJanssen MarvinJanssen linked a pull request Feb 12, 2022 that will close this issue
feat: estimateTransaction #13
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarvinJanssen MarvinJanssen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: estimateTransaction stacks-network/send-many-stx-cli
3 participants
@diwakergupta @wileyj @MarvinJanssen