Fix tests that have reward cycle starting on boundary. Still need to fix pox_treatment

Signed-off-by: Jacinta Ferrant <[email protected]>

Author: jacinta-stacks

stackslib/src/chainstate/nakamoto/coordinator/tests.rs

@@ -938,7 +938,7 @@ fn block_descendant() {
         .collect::<Vec<_>>();
     let test_signers = TestSigners::new(vec![signing_key]);
     let mut pox_constants = TestChainstateConfig::default().burnchain.pox_constants;
-    pox_constants.reward_cycle_length = 10;
+    pox_constants.reward_cycle_length = 8;
     pox_constants.v2_unlock_height = 21;
     pox_constants.pox_3_activation_height = 26;
     pox_constants.v3_unlock_height = 27;
@@ -1027,7 +1027,7 @@ fn block_info_tests(use_primary_testnet: bool) {
         .collect::<Vec<_>>();
     let test_signers = TestSigners::new(vec![signing_key]);
     let mut pox_constants = TestChainstateConfig::default().burnchain.pox_constants;
-    pox_constants.reward_cycle_length = 10;
+    pox_constants.reward_cycle_length = 8;
     pox_constants.v2_unlock_height = 21;
     pox_constants.pox_3_activation_height = 26;
     pox_constants.v3_unlock_height = 27;
@@ -1462,7 +1462,7 @@ fn pox_treatment() {
         .collect::<Vec<_>>();
     let test_signers = TestSigners::new(vec![signing_key]);
     let mut pox_constants = TestChainstateConfig::default().burnchain.pox_constants;
-    pox_constants.reward_cycle_length = 10;
+    pox_constants.reward_cycle_length = 8;
     pox_constants.v2_unlock_height = 21;
     pox_constants.pox_3_activation_height = 26;
     pox_constants.v3_unlock_height = 27;
@@ -1780,7 +1780,7 @@ fn transactions_not_indexing() {
         .collect::<Vec<_>>();
     let test_signers = TestSigners::new(vec![signing_key]);
     let mut pox_constants = TestChainstateConfig::default().burnchain.pox_constants;
-    pox_constants.reward_cycle_length = 10;
+    pox_constants.reward_cycle_length = 8;
     pox_constants.v2_unlock_height = 21;
     pox_constants.pox_3_activation_height = 26;
     pox_constants.v3_unlock_height = 27;
@@ -3893,7 +3893,7 @@ fn process_next_nakamoto_block_deadlock() {
         .collect::<Vec<_>>();
     let test_signers = TestSigners::new(vec![signing_key]);
     let mut pox_constants = TestChainstateConfig::default().burnchain.pox_constants;
-    pox_constants.reward_cycle_length = 10;
+    pox_constants.reward_cycle_length = 8;
     pox_constants.v2_unlock_height = 21;
     pox_constants.pox_3_activation_height = 26;
     pox_constants.v3_unlock_height = 27;