-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Apply new lints in Clippy 1.78 #4780
chore: Apply new lints in Clippy 1.78 #4780
Conversation
@jbencin in the interest of prioritizing nakamoto work - can we put this in draft, or even delete (for now) and create an issue to track this after 3.0 is done? working on this now could be time-consuming due to the amount of changes, and would most likely cause a lot of issues downstream with other PR's. |
@wileyj It's not high priority, you can ignore it for now, I just had some time to kill today while waiting on other things. But it's not a big PR and I can't imagine it would mess anything up |
understood. I'm just anticipating downstream conflicts that would require
some refactoring. let's pick this up after 3.0
…On Fri, May 10, 2024 at 16:54 Jeff Bencin ***@***.***> wrote:
@wileyj <https://github.com/wileyj> It's not high priority, you can
ignore it for now, I just had some time to kill today while waiting on
other things. But it's not a big PR and I can't imagine it would mess
anything up
—
Reply to this email directly, view it on GitHub
<#4780 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVXIHAZDMQH6AZKUBS5IYTZBVM4VAVCNFSM6AAAAABHRIO6QSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVGM4TCMBQGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Closing because it's too old to merge/rebase without major conflicts. Re-applied the lints and created #5643 instead |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Apply lints introduced in recent Clippy release (1.78) to this repository. See Clippy changelog for lints that were introduced