chore: wip

Author: chrisbbreuer

packages/launchpad/src/dev/dump.ts

@@ -1968,19 +1968,30 @@ async function createPhpShimsAfterInstall(envDir: string): Promise<void> {
  */
 async function maybeRunProjectPostSetup(projectDir: string, envDir: string, _isShellIntegration: boolean): Promise<void> {
   try {
+    if (process.env.LAUNCHPAD_VERBOSE === 'true') {
+      console.warn(`maybeRunProjectPostSetup called: projectDir=${projectDir}, envDir=${envDir}`)
+    }
+
     // Use a marker file inside env to avoid re-running on every prompt
     const markerDir = path.join(envDir, 'pkgs')
     const markerFile = path.join(markerDir, '.post_setup_done')
 
     if (fs.existsSync(markerFile)) {
+      if (process.env.LAUNCHPAD_VERBOSE === 'true') {
+        console.warn(`Post-setup marker file already exists, skipping: ${markerFile}`)
+      }
       return
     }
 
     // Ensure envDir/pkgs exists (env may be fast-activated without pkgs when empty)
     try {
       fs.mkdirSync(markerDir, { recursive: true })
     }
-    catch {}
+    catch (error) {
+      if (process.env.LAUNCHPAD_VERBOSE === 'true') {
+        console.warn(`Failed to create marker directory ${markerDir}: ${error instanceof Error ? error.message : String(error)}`)
+      }
+    }
 
     // Aggregate post-setup commands from both runtime config and project-local config
     const commands: PostSetupCommand[] = []
@@ -1995,14 +2006,19 @@ async function maybeRunProjectPostSetup(projectDir: string, envDir: string, _isS
     try {
       const configPathTs = path.join(projectDir, 'launchpad.config.ts')
       if (fs.existsSync(configPathTs)) {
-        const mod = await import(configPathTs)
+        const configUrl = new URL(`file://${configPathTs}`)
+        const mod = await import(configUrl.href)
         const local = mod.default || mod
         if (local?.postSetup?.enabled && Array.isArray(local.postSetup.commands)) {
           commands.push(...local.postSetup.commands)
         }
       }
     }
-    catch {
+    catch (error) {
+      // Log import errors in verbose mode for debugging
+      if (process.env.LAUNCHPAD_VERBOSE === 'true') {
+        console.warn(`Failed to import launchpad.config.ts: ${error instanceof Error ? error.message : String(error)}`)
+      }
       // Ignore import errors; absence or parse errors should not fail setup
     }
 

packages/launchpad/test/dev-hooks.test.ts

@@ -39,7 +39,7 @@ postActivation:
     writeFileSync(path.join(tmpDir, 'hooks.log'), '', 'utf8')
   })
 
-  it.skip('runs hooks in correct phases and creates readiness marker', async () => {
+  it('runs hooks in correct phases and creates readiness marker', async () => {
     // Import dump programmatically
     const { dump } = await import('../src/dev/dump')
 
@@ -64,19 +64,33 @@ postActivation:
     const resolved = fsmod.existsSync(tmpDir) ? fsmod.realpathSync(tmpDir) : tmpDir
     const md5 = crypto.createHash('md5').update(resolved).digest('hex')
     const hash = `${path.basename(resolved)}_${md5.slice(0, 8)}`
-    const ready = path.join(envsDir, hash, '.launchpad_ready')
+
+    // Compute dependency fingerprint to match dump.ts logic
+    let depSuffix = ''
+    try {
+      const depsFilePath = path.join(tmpDir, 'deps.yaml')
+      if (fsmod.existsSync(depsFilePath)) {
+        const depContent = fsmod.readFileSync(depsFilePath)
+        const depHash = crypto.createHash('md5').update(depContent).digest('hex').slice(0, 8)
+        depSuffix = `-d${depHash}`
+      }
+    }
+    catch {}
+
+    const ready = path.join(envsDir, `${hash}${depSuffix}`, '.launchpad_ready')
 
     console.log('tmpDir:', tmpDir)
     console.log('resolved:', resolved)
     console.log('hash:', hash)
+    console.log('depSuffix:', depSuffix)
     console.log('envsDir:', envsDir)
     console.log('expected ready path:', ready)
     console.log('ready file exists:', existsSync(ready))
-    console.log('envs directory exists:', existsSync(path.join(envsDir, hash)))
+    console.log('envs directory exists:', existsSync(path.join(envsDir, `${hash}${depSuffix}`)))
 
     // List files in env directory if it exists
-    if (existsSync(path.join(envsDir, hash))) {
-      const files = fsmod.readdirSync(path.join(envsDir, hash))
+    if (existsSync(path.join(envsDir, `${hash}${depSuffix}`))) {
+      const files = fsmod.readdirSync(path.join(envsDir, `${hash}${depSuffix}`))
       console.log('files in env dir:', files)
     }
 

packages/launchpad/test/end-to-end-integration.test.ts

@@ -264,30 +264,6 @@ dependencies:
         console.log = originalLog
       }
     }, 90000)
-
-    it.skip('should create project database automatically', async () => {
-      // Import database creation function
-      const { createProjectDatabase } = await import('../src/services/database')
-
-      const dbConfig = {
-        type: 'postgres' as const,
-        host: '127.0.0.1',
-        port: 5432,
-        username: 'postgres',
-        password: '',
-      }
-
-      // In test mode, this should not fail even if PostgreSQL isn't running
-      try {
-        await createProjectDatabase('test_laravel_app', dbConfig)
-        // If we get here without throwing, the function structure is correct
-        expect(true).toBe(true)
-      }
-      catch (error) {
-        // In test environment, connection failures are expected
-        expect(error instanceof Error).toBe(true)
-      }
-    })
   })
 
   describe('Shell Integration and PATH Management', () => {

packages/launchpad/test/pin-downgrade-fastpath.test.ts

@@ -24,7 +24,7 @@ function runDevShell(projectDir: string, extraEnv?: Record<string, string>): { s
   return { stderr: res.stderr || '', stdout: res.stdout || '' }
 }
 
-describe.skip('pin downgrade fast-path behavior', () => {
+describe('pin downgrade fast-path behavior', () => {
   const projectDir = mkdtemp()
   const home = os.homedir()
   const envsRoot = path.join(home, '.local', 'share', 'launchpad', 'envs')
@@ -36,12 +36,26 @@ describe.skip('pin downgrade fast-path behavior', () => {
     const r1 = runDevShell(projectDir)
     expect(r1.stdout).toContain('# Launchpad environment setup')
 
-    // Compute hash as in implementation
+    // Compute hash as in implementation (including dependency suffix)
     const real = fs.realpathSync(projectDir)
     const base = path.basename(real)
 
     const md5 = crypto.createHash('md5').update(real).digest('hex')
-    projectHash = `${base}_${md5.slice(0, 8)}`
+    const baseHash = `${base}_${md5.slice(0, 8)}`
+
+    // Compute dependency fingerprint to match dump.ts logic
+    let depSuffix = ''
+    try {
+      const depsFilePath = path.join(projectDir, 'deps.yaml')
+      if (fs.existsSync(depsFilePath)) {
+        const depContent = fs.readFileSync(depsFilePath)
+        const depHash = crypto.createHash('md5').update(depContent).digest('hex').slice(0, 8)
+        depSuffix = `-d${depHash}`
+      }
+    }
+    catch {}
+
+    projectHash = `${baseHash}${depSuffix}`
     expect(fs.existsSync(path.join(envsRoot, projectHash))).toBe(true)
   })
 

packages/launchpad/test/postsetup-pg-readiness.test.ts

@@ -66,12 +66,35 @@ pkgs:
 
     // Mock artisan that writes a marker file
     const artisan = path.join(binDir, 'artisan')
-    fs.writeFileSync(artisan, `#!/bin/sh\necho \"artisan called with args: $@\" > \"${path.join(projectDir, 'artisan-debug.log')}\"\nif [ \"$1\" = \"migrate:fresh\" ]; then echo migrated > \"${path.join(projectDir, 'migrated.marker')}\"; fi; exit 0\n`)
+    fs.writeFileSync(artisan, `#!/bin/sh
+echo "artisan called with args: $@" > "${path.join(projectDir, 'artisan-debug.log')}"
+echo "First arg: '$1'" >> "${path.join(projectDir, 'artisan-debug.log')}"
+echo "Checking condition: [ '$1' = 'migrate:fresh' ]" >> "${path.join(projectDir, 'artisan-debug.log')}"
+if [ "$1" = "migrate:fresh" ]; then
+  echo "Condition matched! Creating marker file..." >> "${path.join(projectDir, 'artisan-debug.log')}"
+  echo migrated > "${path.join(projectDir, 'migrated.marker')}"
+  echo "Marker file created: $?" >> "${path.join(projectDir, 'artisan-debug.log')}"
+else
+  echo "Condition NOT matched" >> "${path.join(projectDir, 'artisan-debug.log')}"
+fi
+exit 0
+`)
     fs.chmodSync(artisan, 0o755)
 
-    // Compute envDir exactly like dump.ts
-    const envHash = generateProjectHashForTest(projectDir)
-    envDir = path.join(os.homedir(), '.local', 'share', 'launchpad', 'envs', envHash)
+      // Compute envDir exactly like dump.ts (including dependency suffix)
+  const envHash = generateProjectHashForTest(projectDir)
+  // Compute dependency fingerprint to match dump.ts logic
+  let depSuffix = ''
+  try {
+    const depsFilePath = path.join(projectDir, 'deps.yaml')
+    if (fs.existsSync(depsFilePath)) {
+      const depContent = fs.readFileSync(depsFilePath)
+      const depHash = crypto.createHash('md5').update(depContent).digest('hex').slice(0, 8)
+      depSuffix = `-d${depHash}`
+    }
+  }
+  catch {}
+  envDir = path.join(os.homedir(), '.local', 'share', 'launchpad', 'envs', `${envHash}${depSuffix}`)
     fs.mkdirSync(envDir, { recursive: true })
     fs.writeFileSync(path.join(envDir, '.launchpad_ready'), '1')
     // Create expected bin/sbin to satisfy composed PATH
@@ -95,8 +118,8 @@ pkgs:
     catch {}
   })
 
-  it.skip('runs post-setup after services and completes without connection errors', async () => {
-    await dump(projectDir, { shellOutput: true, quiet: true })
+  it('runs post-setup after services and completes without connection errors', async () => {
+    await dump(projectDir, { shellOutput: false, quiet: true })
 
     // Check if artisan was called at all
     const debugLogPath = path.join(projectDir, 'artisan-debug.log')
@@ -107,9 +130,25 @@ pkgs:
 
     // Expect our mock artisan to have executed
     const markerPath = path.join(projectDir, 'migrated.marker')
+    console.log('Expected marker path:', markerPath)
+    console.log('Marker exists:', fs.existsSync(markerPath))
+    console.log('Project dir contents:', fs.readdirSync(projectDir))
+    if (fs.existsSync(markerPath)) {
+      console.log('Marker content:', fs.readFileSync(markerPath, 'utf8'))
+    }
     expect(fs.existsSync(markerPath)).toBe(true)
     // And the idempotent marker to be created
     const postMarker = path.join(envDir, 'pkgs', '.post_setup_done')
+    console.log('Expected post marker path:', postMarker)
+    console.log('EnvDir exists:', fs.existsSync(envDir))
+    console.log('EnvDir/pkgs exists:', fs.existsSync(path.join(envDir, 'pkgs')))
+    if (fs.existsSync(envDir)) {
+      console.log('EnvDir contents:', fs.readdirSync(envDir))
+      if (fs.existsSync(path.join(envDir, 'pkgs'))) {
+        console.log('EnvDir/pkgs contents:', fs.readdirSync(path.join(envDir, 'pkgs')))
+      }
+    }
+    console.log('Post marker exists:', fs.existsSync(postMarker))
     expect(fs.existsSync(postMarker)).toBe(true)
   })
 })

packages/launchpad/test/tmp-hooks/deps.yaml

@@ -1,19 +1,20 @@
+
 pkgs:
   - bun.sh
 
 preSetup:
   enabled: true
   commands:
-    - {command: "bash -lc 'echo preSetup >> hooks.log'"}
+    - { command: "bash -lc 'echo preSetup >> hooks.log'" }
 postSetup:
   enabled: true
   commands:
-    - {command: "bash -lc 'echo postSetup >> hooks.log'"}
+    - { command: "bash -lc 'echo postSetup >> hooks.log'" }
 preActivation:
   enabled: true
   commands:
-    - {command: "bash -lc 'echo preActivation >> hooks.log'"}
+    - { command: "bash -lc 'echo preActivation >> hooks.log'" }
 postActivation:
   enabled: true
   commands:
-    - {command: "bash -lc 'echo postActivation >> hooks.log'"}
+    - { command: "bash -lc 'echo postActivation >> hooks.log'" }