chore: wip

Author: chrisbbreuer

deps.yaml

@@ -1,2 +1,2 @@
 dependencies:
-  bun.sh: 1.2.19
+  bun.sh: 1.2.20

package.json

@@ -21,6 +21,11 @@
     "build": "for dir in packages/*; do if [ -f \"$dir/package.json\" ]; then echo \"Building $dir\" && bun run --cwd $dir build; fi; done",
     "lint": "bunx --bun eslint .",
     "lint:fix": "bunx --bun eslint . --fix",
+    "pickier": "./packages/pickier/pickier run . --mode auto",
+    "pickier:lint": "./packages/pickier/pickier run . --mode lint",
+    "pickier:lint:fix": "./packages/pickier/pickier run . --mode lint --fix",
+    "pickier:format:check": "./packages/pickier/pickier run . --mode format --check",
+    "pickier:format:write": "./packages/pickier/pickier run . --mode format --write",
     "fresh": "bunx rimraf node_modules/ bun.lock && bun i",
     "changelog": "bunx logsmith --verbose",
     "changelog:generate": "bunx logsmith --output CHANGELOG.md",

packages/pickier/src/config.ts

@@ -2,7 +2,26 @@ import type { PickierConfig } from './types'
 import { loadConfig } from 'bunfig'
 
 export const defaultConfig: PickierConfig = {
-  ignores: ['**/node_modules/**', '**/dist/**', '**/build/**', '**/vendor/**', '**/coverage/**'],
+  ignores: [
+    '**/node_modules/**',
+    '**/.pnpm/**',
+    '**/.yarn/**',
+    '**/dist/**',
+    '**/build/**',
+    '**/out/**',
+    '**/.output/**',
+    '**/.next/**',
+    '**/.nuxt/**',
+    '**/.vite/**',
+    '**/.turbo/**',
+    '**/.cache/**',
+    '**/coverage/**',
+    '**/vendor/**',
+    '**/tmp/**',
+    '**/.git/**',
+    '**/.idea/**',
+    '**/.vscode/**',
+  ],
   lint: {
     extensions: ['ts', 'js', 'html', 'css', 'json', 'jsonc', 'md', 'yaml', 'yml', 'stx'],
     reporter: 'stylish',

packages/pickier/src/formatter.ts

@@ -6,7 +6,7 @@ import process from 'node:process'
 import { glob as tinyGlob } from 'tinyglobby'
 import { formatCode } from './format'
 import { getAllPlugins } from './plugins'
-import { colors, expandPatterns, loadConfigFromPath } from './utils'
+import { colors, expandPatterns, loadConfigFromPath, shouldIgnorePath } from './utils'
 
 function trace(...args: any[]) {
   if (process.env.PICKIER_TRACE === '1')
@@ -128,6 +128,8 @@ export async function runFormat(globs: string[], options: FormatOptions): Promis
         for (const it of items) {
           const full = join(dir, it)
           const st = statSync(full)
+          if (shouldIgnorePath(full, cfg.ignores))
+            continue
           if (st.isDirectory())
             stack.push(full)
           else
@@ -156,6 +158,8 @@ export async function runFormat(globs: string[], options: FormatOptions): Promis
   trace('globbed entries', entries.length)
 
   const files = entries.filter((f) => {
+    if (shouldIgnorePath(f, cfg.ignores))
+      return false
     const idx = f.lastIndexOf('.')
     if (idx < 0)
       return true // include files without extensions (edge-case test expects this)

packages/pickier/src/index.ts

@@ -1,11 +1,9 @@
 export { config, defaultConfig } from './config'
 export * from './format'
 export { runFormat } from './formatter'
+export { lintText, runLint, runLintProgrammatic } from './linter'
+export { runUnified as run } from './run'
 
-export { runLint } from './linter'
-export { lintText, runLintProgrammatic } from './linter'
-// Unified CLI API
-export { run } from './run'
 export type { RunOptions } from './run'
 
 export * from './types'

packages/pickier/src/linter.ts

@@ -1,13 +1,13 @@
 /* eslint-disable no-console */
 import type { LintIssue, LintOptions, PickierConfig, PickierPlugin, RuleContext, RulesConfigMap } from './types'
 import { readFileSync, writeFileSync } from 'node:fs'
-import { relative } from 'node:path'
+import { isAbsolute, relative, resolve } from 'node:path'
 import process from 'node:process'
 import { glob as tinyGlob } from 'tinyglobby'
 import { detectQuoteIssues, hasIndentIssue } from './format'
 import { formatStylish } from './formatter'
 import { getAllPlugins } from './plugins'
-import { colors, expandPatterns, isCodeFile, loadConfigFromPath } from './utils'
+import { colors, expandPatterns, isCodeFile, loadConfigFromPath, shouldIgnorePath } from './utils'
 
 function trace(...args: any[]) {
   if (process.env.PICKIER_TRACE === '1')
@@ -79,19 +79,22 @@ export async function runLintProgrammatic(
     try {
       const { statSync } = await import('node:fs')
       const st = statSync(patterns[0])
-      if (st.isFile())
-        entries = [patterns[0]]
+      if (st.isFile()) {
+        const abs = isAbsolute(patterns[0]) ? patterns[0] : resolve(process.cwd(), patterns[0])
+        entries = [abs]
+      }
     }
     catch {}
   }
 
   const simpleDirPattern = patterns.length === 1 && /\*\*\/*\*$/.test(patterns[0])
   if (!entries.length && simpleDirPattern) {
     const base = patterns[0].replace(/\/?\*\*\/*\*\*?$/, '')
+    const rootBase = isAbsolute(base) ? base : resolve(process.cwd(), base)
     try {
       const { readdirSync, statSync } = await import('node:fs')
       const { join } = await import('node:path')
-      const stack: string[] = [base]
+      const stack: string[] = [rootBase]
       while (stack.length) {
         if (signal?.aborted)
           throw new Error('AbortError')
@@ -100,6 +103,8 @@ export async function runLintProgrammatic(
         for (const it of items) {
           const full = join(dir, it)
           const st = statSync(full)
+          if (shouldIgnorePath(full, cfg.ignores))
+            continue
           if (st.isDirectory())
             stack.push(full)
           else entries.push(full)
@@ -126,7 +131,19 @@ export async function runLintProgrammatic(
 
   if (signal?.aborted)
     throw new Error('AbortError')
-  const files = entries.filter((f: string) => isCodeFile(f, extSet))
+  // filter with trace counters
+  let cntTotal = 0; let cntIncluded = 0; let cntNodeModules = 0; let cntIgnored = 0; let cntWrongExt = 0
+  const files: string[] = []
+  for (const f of entries) {
+    cntTotal++
+    const p = f.replace(/\\/g, '/')
+    if (p.includes('/node_modules/')) { cntNodeModules++; continue }
+    if (shouldIgnorePath(f, cfg.ignores)) { cntIgnored++; continue }
+    if (!isCodeFile(f, extSet)) { cntWrongExt++; continue }
+    files.push(f)
+    cntIncluded++
+  }
+  trace('filter:programmatic', { total: cntTotal, included: cntIncluded, node_modules: cntNodeModules, ignored: cntIgnored, wrongExt: cntWrongExt })
 
   let allIssues: LintIssue[] = []
   for (const file of files) {
@@ -628,13 +645,16 @@ export async function runLint(globs: string[], options: LintOptions): Promise<nu
       try {
         const { readdirSync, statSync } = await import('node:fs')
         const { join } = await import('node:path')
-        const stack: string[] = [base]
+        const rootBase = isAbsolute(base) ? base : resolve(process.cwd(), base)
+        const stack: string[] = [rootBase]
         while (stack.length) {
           const dir = stack.pop()!
           const items = readdirSync(dir)
           for (const it of items) {
             const full = join(dir, it)
             const st = statSync(full)
+            if (shouldIgnorePath(full, cfg.ignores))
+              continue
             if (st.isDirectory())
               stack.push(full)
             else
@@ -662,7 +682,19 @@ export async function runLint(globs: string[], options: LintOptions): Promise<nu
     }
 
     trace('globbed entries', entries.length)
-    const files = entries.filter((f: string) => isCodeFile(f, extSet))
+    // filter with trace counters
+    let cntTotal = 0; let cntIncluded = 0; let cntNodeModules = 0; let cntIgnored = 0; let cntWrongExt = 0
+    const files: string[] = []
+    for (const f of entries) {
+      cntTotal++
+      const p = f.replace(/\\/g, '/')
+      if (p.includes('/node_modules/')) { cntNodeModules++; continue }
+      if (shouldIgnorePath(f, cfg.ignores)) { cntIgnored++; continue }
+      if (!isCodeFile(f, extSet)) { cntWrongExt++; continue }
+      files.push(f)
+      cntIncluded++
+    }
+    trace('filter:cli', { total: cntTotal, included: cntIncluded, node_modules: cntNodeModules, ignored: cntIgnored, wrongExt: cntWrongExt })
     trace('filtered files', files.length)
 
     let allIssues: LintIssue[] = []

packages/pickier/src/plugins/pickier.ts

@@ -1,9 +1,9 @@
 import type { PickierPlugin } from '../types'
+import { noUnusedVarsRule } from '../rules/general/no-unused-vars'
+import { preferConstRule } from '../rules/general/prefer-const'
 import { importDedupeRule } from '../rules/imports/import-dedupe'
 import { noImportDistRule } from '../rules/imports/no-import-dist'
 import { noImportNodeModulesByPathRule } from '../rules/imports/no-import-node-modules-by-path'
-import { noUnusedVarsRule } from '../rules/general/no-unused-vars'
-import { preferConstRule } from '../rules/general/prefer-const'
 import { sortExportsRule } from '../rules/sort/exports'
 import { sortHeritageClausesRule } from '../rules/sort/heritage-clauses'
 import { sortImportsRule } from '../rules/sort/imports'

packages/pickier/src/run.ts

@@ -5,7 +5,7 @@ export type RunOptions = (Partial<LintOptions> & Partial<FormatOptions>) & {
   mode?: 'auto' | 'lint' | 'format'
 }
 
-export async function run(globs: string[], options: RunOptions): Promise<number> {
+export async function runUnified(globs: string[], options: RunOptions): Promise<number> {
   const mode = options.mode || 'auto'
   if (mode === 'lint')
     return runLint(globs, options as LintOptions)

packages/pickier/src/utils.ts

@@ -98,3 +98,41 @@ export function isCodeFile(file: string, allowedExts: Set<string>): boolean {
   const ext = file.slice(idx)
   return allowedExts.has(ext)
 }
+
+// Basic POSIX-like normalization for matching
+function toPosixPath(p: string): string {
+  return p.replace(/\\/g, '/').replace(/\/+/g, '/')
+}
+
+/**
+ * Lightweight ignore matcher supporting common patterns like double-star slash dir slash double-star.
+ * (Example: patterns matching any path segment named "dir" recursively.)
+ * Not a full glob engine; optimized for directory skip checks in manual traversal.
+ */
+export function shouldIgnorePath(absPath: string, ignoreGlobs: string[]): boolean {
+  const rel = toPosixPath(absPath.startsWith(process.cwd())
+    ? absPath.slice(process.cwd().length)
+    : absPath)
+  // quick checks for typical patterns **/name/**
+  for (const g of ignoreGlobs) {
+    // normalize
+    const gg = toPosixPath(g.trim())
+    // handle patterns like any-depth/name/any-depth (including dot-prefixed names)
+    const m = gg.match(/\*\*\/(.+?)\/\*\*$/)
+    if (m) {
+      const name = m[1]
+      if (rel.includes(`/${name}/`) || rel.endsWith(`/${name}`))
+        return true
+      continue
+    }
+    // handle any-depth/name (no trailing any-depth)
+    const m2 = gg.match(/\*\*\/(.+)$/)
+    if (m2) {
+      const name = m2[1].replace(/\/$/, '')
+      if (rel.includes(`/${name}/`) || rel.endsWith(`/${name}`))
+        return true
+      continue
+    }
+  }
+  return false
+}

packages/pickier/test/ignored-dirs-cli.test.ts

@@ -0,0 +1,42 @@
+import { describe, expect, it } from 'bun:test'
+import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from 'node:fs'
+import { tmpdir } from 'node:os'
+import { join } from 'node:path'
+import { runLint } from '../src/linter'
+
+function tmpdirPickier(): string {
+  return mkdtempSync(join(tmpdir(), 'pickier-ignore-cli-'))
+}
+
+describe('ignored directories are not scanned (CLI path runLint)', () => {
+  it('does not scan node_modules', async () => {
+    const dir = tmpdirPickier()
+    try {
+      const nmFile = join(dir, 'node_modules', 'pako', 'index.ts')
+      mkdirSync(join(dir, 'node_modules', 'pako'), { recursive: true })
+      writeFileSync(nmFile, 'console.log(1)\ndebugger\n', 'utf8')
+
+      // nothing else; if node_modules were scanned, code would be 1 due to debugger
+      const code = await runLint([dir], { reporter: 'json', maxWarnings: -1 })
+      expect(code).toBe(0)
+    }
+    finally {
+      rmSync(dir, { recursive: true, force: true })
+    }
+  })
+
+  it('does not scan dist', async () => {
+    const dir = tmpdirPickier()
+    try {
+      const distFile = join(dir, 'dist', 'x.ts')
+      mkdirSync(join(dir, 'dist'), { recursive: true })
+      writeFileSync(distFile, 'console.log(1)\ndebugger\n', 'utf8')
+
+      const code = await runLint([dir], { reporter: 'json', maxWarnings: -1 })
+      expect(code).toBe(0)
+    }
+    finally {
+      rmSync(dir, { recursive: true, force: true })
+    }
+  })
+})