From b852cf01abf6a74297ae869b6b0725d63baaab37 Mon Sep 17 00:00:00 2001 From: Muneeb Aijaz <43588696+MuneebAijaz@users.noreply.github.com> Date: Thu, 1 Aug 2024 00:40:09 +0500 Subject: [PATCH] Switch PR workflow to pull_request (#429) * Switch PR workflow to pull_request * Update pull_request.yaml --- .github/workflows/pull_request.yaml | 134 +++++++++++----------------- 1 file changed, 51 insertions(+), 83 deletions(-) diff --git a/.github/workflows/pull_request.yaml b/.github/workflows/pull_request.yaml index 92d9a830..71b7f2e4 100644 --- a/.github/workflows/pull_request.yaml +++ b/.github/workflows/pull_request.yaml @@ -1,7 +1,7 @@ name: Pull Request on: - pull_request_target: + pull_request: branches: - master @@ -46,27 +46,27 @@ jobs: cd deployments/kubernetes/chart/forecastle helm lint - - name: Install kubectl - run: | - curl -LO "https://storage.googleapis.com/kubernetes-release/release/v${KUBERNETES_VERSION}/bin/linux/amd64/kubectl" - sudo install ./kubectl /usr/local/bin/ && rm kubectl - kubectl version --short --client - kubectl version --short --client | grep -q ${KUBERNETES_VERSION} - - - name: Install Kind - run: | - curl -L -o kind https://github.com/kubernetes-sigs/kind/releases/download/v${KIND_VERSION}/kind-linux-amd64 - sudo install ./kind /usr/local/bin && rm kind - kind version - kind version | grep -q ${KIND_VERSION} - - - name: Create Kind Cluster - run: | - kind create cluster - kubectl cluster-info + # - name: Install kubectl + # run: | + # curl -LO "https://storage.googleapis.com/kubernetes-release/release/v${KUBERNETES_VERSION}/bin/linux/amd64/kubectl" + # sudo install ./kubectl /usr/local/bin/ && rm kubectl + # kubectl version --short --client + # kubectl version --short --client | grep -q ${KUBERNETES_VERSION} + + # - name: Install Kind + # run: | + # curl -L -o kind https://github.com/kubernetes-sigs/kind/releases/download/v${KIND_VERSION}/kind-linux-amd64 + # sudo install ./kind /usr/local/bin && rm kind + # kind version + # kind version | grep -q ${KIND_VERSION} + + # - name: Create Kind Cluster + # run: | + # kind create cluster + # kubectl cluster-info - - name: Test - run: make test + # - name: Test + # run: make test - name: Generate Tag id: generate_tag @@ -81,24 +81,19 @@ jobs: - name: Set up Docker Buildx uses: docker/setup-buildx-action@v3 - - name: Login to ghcr registry - uses: docker/login-action@v3 - with: - registry: ${{env.REGISTRY}} - username: stakater-user - password: ${{secrets.GITHUB_TOKEN}} - - name: Generate image repository path for ghcr registry run: | echo GHCR_IMAGE_REPOSITORY=${{env.REGISTRY}}/$(echo ${{ github.repository }} | tr '[:upper:]' '[:lower:]') >> $GITHUB_ENV - - name: Build and Push image to ghcr registry + # To identify any broken changes in dockerfiles or dependencies + + - name: Build image uses: docker/build-push-action@v5 with: context: . file: ${{ env.DOCKER_FILE_PATH }} pull: true - push: true + push: false cache-to: type=inline build-args: BUILD_PARAMETERS=${{ env.BUILD_PARAMETERS }} platforms: linux/amd64,linux/arm,linux/arm64 @@ -109,56 +104,29 @@ jobs: org.opencontainers.image.created=${{ steps.prep.outputs.created }} org.opencontainers.image.revision=${{ github.sha }} - - name: Login to Registry for DockerHub - uses: docker/login-action@v3 - with: - username: ${{ secrets.STAKATER_DOCKERHUB_USERNAME }} - password: ${{ secrets.STAKATER_DOCKERHUB_PASSWORD }} - - - name: Generate image repository path for DockerHub registry - run: | - echo IMAGE_REPOSITORY=$(echo ${{ github.repository }} | tr '[:upper:]' '[:lower:]') >> $GITHUB_ENV - - - name: Build and Push Docker Image to DockerHub registry - uses: docker/build-push-action@v5 - with: - context: . - file: ${{ env.DOCKER_FILE_PATH }} - pull: true - push: true - build-args: BUILD_PARAMETERS=${{ env.BUILD_PARAMETERS }} - cache-to: type=inline - platforms: linux/amd64,linux/arm,linux/arm64 - tags: | - ${{ env.IMAGE_REPOSITORY }}:${{ steps.generate_tag.outputs.GIT_TAG }} - labels: | - org.opencontainers.image.source=${{ github.event.repository.clone_url }} - org.opencontainers.image.created=${{ steps.prep.outputs.created }} - org.opencontainers.image.revision=${{ github.sha }} - - - name: Comment on PR - uses: mshick/add-pr-comment@v2 - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - with: - message: '@${{ github.actor }} Image is available for testing. `docker pull ${{ env.GHCR_IMAGE_REPOSITORY }}:${{ steps.generate_tag.outputs.GIT_TAG }}`' - allow-repeats: true - - - name: Notify Failure - if: failure() - uses: mshick/add-pr-comment@v2 - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - with: - message: '@${{ github.actor }} Yikes! You better fix it before anyone else finds out! [Build](https://github.com/${{ github.repository }}/commit/${{ github.event.pull_request.head.sha }}/checks) has Failed!' - allow-repeats: true - - - name: Notify Slack - uses: 8398a7/action-slack@v3 - if: always() # Pick up events even if the job fails or is canceled. - with: - status: ${{ job.status }} - fields: repo,author,action,eventName,ref,workflow - env: - GITHUB_TOKEN: ${{ secrets.STAKATER_GITHUB_TOKEN }} - SLACK_WEBHOOK_URL: ${{ secrets.STAKATER_DELIVERY_SLACK_WEBHOOK }} + # - name: Comment on PR + # uses: mshick/add-pr-comment@v2 + # env: + # GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + # with: + # message: '@${{ github.actor }} Image is available for testing. `docker pull ${{ env.GHCR_IMAGE_REPOSITORY }}:${{ steps.generate_tag.outputs.GIT_TAG }}`' + # allow-repeats: true + + # - name: Notify Failure + # if: failure() + # uses: mshick/add-pr-comment@v2 + # env: + # GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + # with: + # message: '@${{ github.actor }} Yikes! You better fix it before anyone else finds out! [Build](https://github.com/${{ github.repository }}/commit/${{ github.event.pull_request.head.sha }}/checks) has Failed!' + # allow-repeats: true + + # - name: Notify Slack + # uses: 8398a7/action-slack@v3 + # if: always() # Pick up events even if the job fails or is canceled. + # with: + # status: ${{ job.status }} + # fields: repo,author,action,eventName,ref,workflow + # env: + # GITHUB_TOKEN: ${{ secrets.STAKATER_GITHUB_TOKEN }} + # SLACK_WEBHOOK_URL: ${{ secrets.STAKATER_DELIVERY_SLACK_WEBHOOK }}