Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingress): fallback to status host if defined #446

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(ingress): fallback to status host if defined #446

wants to merge 1 commit into from

Conversation

aslafy-z
Copy link
Contributor

@aslafy-z aslafy-z commented Oct 2, 2024 •
edited
Loading

  • Introduce fallback logic to use the Ingress status host if defined when determining the ingress URL.
  • Remove rule requirement (support for spec.defaultBackend) .

Priority order:

  1. spec.tls[0].hosts[0]
  2. spec.rules[0].host
  3. status.loadBalancer.ingress[0].hostname
  4. status.loadBalancer.ingress[0].ip

Fixes #440

@aslafy-z aslafy-z marked this pull request as ready for review November 9, 2024 15:31
@aslafy-z
Copy link
Contributor Author

aslafy-z commented Nov 9, 2024

@MuneebAijaz Can you please approve the CI runs? Thank you

@aslafy-z
Copy link
Contributor Author

aslafy-z commented Nov 9, 2024

@MuneebAijaz Can you please approve again the CI runs? I ran tests locally. Thank you

@MuneebAijaz MuneebAijaz added the ok-to-test Label for running e2e tests label Nov 9, 2024
@aslafy-z aslafy-z mentioned this pull request Nov 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ok-to-test Label for running e2e tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENHANCE] forecastle should read the ingress host from the status instead of the spec
2 participants
@aslafy-z @MuneebAijaz