From a5d574b60a25537ded1e590a0b7741722572edf0 Mon Sep 17 00:00:00 2001 From: MuneebAijaz Date: Thu, 1 Aug 2024 00:35:33 +0500 Subject: [PATCH] Switch PR workflow to pull_request --- .github/workflows/pull_request.yml | 63 ++++++++++++++---------------- 1 file changed, 29 insertions(+), 34 deletions(-) diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 86ea395..8278eee 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -1,7 +1,7 @@ name: Pull Request on: - pull_request_target: + pull_request: branches: - master @@ -45,24 +45,19 @@ jobs: - name: Set up Docker Buildx uses: docker/setup-buildx-action@v3 - - name: Login to Registry - uses: docker/login-action@v3 - with: - username: ${{ secrets.STAKATER_DOCKERHUB_USERNAME }} - password: ${{ secrets.STAKATER_DOCKERHUB_PASSWORD }} - - name: Generate image repository path run: | echo IMAGE_REPOSITORY=$(echo ${{ github.repository }} | tr '[:upper:]' '[:lower:]') >> $GITHUB_ENV - - name: Build and push + # To identify any broken changes in dockerfiles or dependencies + + - name: Build image uses: docker/build-push-action@v6 with: context: . file: ${{ env.DOCKER_FILE_PATH }} pull: true - push: true - build-args: GIT_ACCESS_TOKEN=${{ secrets.STAKATER_GITHUB_TOKEN }} + push: false cache-to: type=inline tags: | ${{ env.IMAGE_REPOSITORY }}:${{ steps.generate_tag.outputs.GIT_TAG }} @@ -71,29 +66,29 @@ jobs: org.opencontainers.image.created=${{ steps.prep.outputs.created }} org.opencontainers.image.revision=${{ github.sha }} - - name: Comment on PR - uses: mshick/add-pr-comment@v2 - env: - GITHUB_TOKEN: ${{ secrets.STAKATER_GITHUB_TOKEN }} - with: - message: '@${{ github.actor }} Image is available for testing. `docker pull ${{ env.IMAGE_REPOSITORY }}:${{ steps.generate_tag.outputs.GIT_TAG }}`' - allow-repeats: false + # - name: Comment on PR + # uses: mshick/add-pr-comment@v2 + # env: + # GITHUB_TOKEN: ${{ secrets.STAKATER_GITHUB_TOKEN }} + # with: + # message: '@${{ github.actor }} Image is available for testing. `docker pull ${{ env.IMAGE_REPOSITORY }}:${{ steps.generate_tag.outputs.GIT_TAG }}`' + # allow-repeats: false - - name: Notify Failure - if: failure() - uses: mshick/add-pr-comment@v2 - env: - GITHUB_TOKEN: ${{ secrets.STAKATER_GITHUB_TOKEN }} - with: - message: '@${{ github.actor }} Yikes! You better fix it before anyone else finds out! [Build](https://github.com/${{ github.repository }}/commit/${{ github.event.pull_request.head.sha }}/checks) has Failed!' - allow-repeats: false + # - name: Notify Failure + # if: failure() + # uses: mshick/add-pr-comment@v2 + # env: + # GITHUB_TOKEN: ${{ secrets.STAKATER_GITHUB_TOKEN }} + # with: + # message: '@${{ github.actor }} Yikes! You better fix it before anyone else finds out! [Build](https://github.com/${{ github.repository }}/commit/${{ github.event.pull_request.head.sha }}/checks) has Failed!' + # allow-repeats: false - - name: Notify Slack - uses: 8398a7/action-slack@v3 - if: always() # Pick up events even if the job fails or is canceled. - with: - status: ${{ job.status }} - fields: repo,author,action,eventName,ref,workflow - env: - GITHUB_TOKEN: ${{ secrets.STAKATER_GITHUB_TOKEN }} - SLACK_WEBHOOK_URL: ${{ secrets.STAKATER_DELIVERY_SLACK_WEBHOOK }} + # - name: Notify Slack + # uses: 8398a7/action-slack@v3 + # if: always() # Pick up events even if the job fails or is canceled. + # with: + # status: ${{ job.status }} + # fields: repo,author,action,eventName,ref,workflow + # env: + # GITHUB_TOKEN: ${{ secrets.STAKATER_GITHUB_TOKEN }} + # SLACK_WEBHOOK_URL: ${{ secrets.STAKATER_DELIVERY_SLACK_WEBHOOK }}