Output for glyphs and sprites #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebrelsford
requested changes
Apr 19, 2023
src/lib/diff.js
Outdated
| @@ -213,6 +223,7 @@ function diffSources(before, after, commands, sourcesRemoved, differ) { | |||
| } else { | |||
| // no update command, must remove then add | |||
| updateSource(sourceId, after, commands, sourcesRemoved); | |||
| // TODO Update differ? | |||
There was a problem hiding this comment.
Would you mind expanding on this? It isn't obvious to me what's actionable here / should there be an issue for it / would it be completely superseded by #19.
There was a problem hiding this comment.
Ah yea, sorry that was a personal note I thought I removed. I'll remove it and open an issue. The way things are structured with now, we don't get super helpful diffs for updating a source url which we do often. It appears as "remove" + "add".
This could be superseded by #19 but I think I may want to open an issue to document separately for posterity anyway.
ebrelsford
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-req to https://github.com/stamen/mapbox-gl-style-diff-viewer/issues/8
This adds glyphs and sprite diffs to the output.
I haven't been in this code in a while, but it looks like this hasn't had much updating since the original code was borrowed from setStyle in GLJS. I think it would be worth opening a follow up here to make all this cleaner for our own purposes since we're kind of just using what's helpful to us in here with a lot of cruft (for us).
[edit]: Opened an issue for cleanup: #19