Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable keep alive in HTTP connections #165

Open
gcampax opened this issue Jun 29, 2021 · 0 comments
Open

Enable keep alive in HTTP connections #165

gcampax opened this issue Jun 29, 2021 · 0 comments
Assignees
@nrser
Labels
enhancement good first issue P1 We're working on it right now

Comments

@gcampax
Copy link
Contributor

gcampax commented Jun 29, 2021

TIL that the default http.Agent used by nodejs does not enable keep-alive, so a new TCP/TLS connection is established for every single outgoing HTTP request. This is very wasteful. We should enable keep alive at least for the requests we make through the Thingpedia Http helpers.
@nrser nrser added the P1 We're working on it right now label Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nrser nrser

Labels
enhancement good first issue P1 We're working on it right now
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nrser @gcampax