Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Olivier's issues/PRs at some point #8

Open
starcraftman opened this issue May 26, 2018 · 1 comment
Open

Review Olivier's issues/PRs at some point #8

starcraftman opened this issue May 26, 2018 · 1 comment
Assignees

Comments

@starcraftman
Copy link
Owner

May be quite a hassle. Will need to make a list here and cross them off one by one. I should probably reply to said tickets that I've pulled/resolved them here after.

@starcraftman starcraftman changed the title Review Original's Issues/PRs at some point. Review Olivier's issues/PRs at some point May 26, 2018
@starcraftman starcraftman self-assigned this May 27, 2018
@starcraftman
Copy link
Owner Author

starcraftman commented Jun 9, 2018

Plan for this issue:

  1. Go through all issues and PRs in reverse chronological order. I will probably track ones I visited here by making an itemized list and crossing them out when suitably handled.
  2. If an issue is relevant, reopen it here and link back while copying the original text and adding thoughts. If an issue is closed by fixes/features or no longer applicable, nothing to do here.
  3. In original issue, I should probably add a note that this is fixed/added/not applicable and try out fork.
  4. PRs will be trickier, especially against python I imagine all rendered uesless. I can still review for ideas or suggestions of things.
  5. As with issues, leave notes where applicable that feature has been resolved/merged/fixed on fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant