Return Option<u64> for u64 - Felt

starknet-io · Oct 4, 2023 · 2db8cfd · 2db8cfd
1 parent 0befb53
commit 2db8cfd
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/crates/stark-felt/src/lib.rs b/crates/stark-felt/src/lib.rs
@@ -556,18 +556,18 @@ mod arithmetic {
     /// Field subtraction. Never overflows/underflows.
     #[allow(clippy::suspicious_arithmetic_impl)]
     impl ops::Sub<Felt> for u64 {
-        type Output = Felt;
+        type Output = Option<u64>;
         fn sub(self, rhs: Felt) -> Self::Output {
-            rhs.neg() + self
+            self + &rhs.neg()
         }
     }
 
     /// Field subtraction. Never overflows/underflows.
     #[allow(clippy::suspicious_arithmetic_impl)]
     impl ops::Sub<&Felt> for u64 {
-        type Output = Felt;
+        type Output = Option<u64>;
         fn sub(self, rhs: &Felt) -> Self::Output {
-            rhs.neg() + self
+            self + &rhs.neg()
         }
     }