Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Souldn't there be a L1HandlerTransaction::compute_message_hash method #218

Open
tdelabro opened this issue Mar 29, 2024 · 0 comments
Open

Comments

@tdelabro
Copy link
Contributor

The rpc method l1_handler_tx_receipt contains a message_hash field:
https://github.com/starkware-libs/starknet-specs/blob/76bdde23c7dae370a3340e40f7ca2ef2520e75b9/api/starknet_api_openrpc.json#L3072

Therefore it seems to be part of the protocol. Maybe a method should be available for the users of this lib to easily compute it, rather than having everyone reimplement it manually.

Here is pathfinder impl:
https://github.com/eqlabs/pathfinder/blob/03f8a58c40c69e60ad29ac6e97d7782aeccad4b4/crates/common/src/transaction.rs#L435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant