Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

txHash field missing in the BLOCK_BODY_WITH_RECEIPTS spec #209

Closed
thiagodeev opened this issue Jun 28, 2024 · 1 comment · May be fixed by #210
Closed

txHash field missing in the BLOCK_BODY_WITH_RECEIPTS spec #209

thiagodeev opened this issue Jun 28, 2024 · 1 comment · May be fixed by #210

Comments

@thiagodeev
Copy link

The BLOCK_BODY_WITH_TXS returns the TXN + TxHash as the TXN doesn't have the txHash on it, but that doesn't happen with the BLOCK_BODY_WITH_RECEIPTS that returns the transactions + the receipts. It should also specify that a transaction hash should be returned as happens with the BLOCK_BODY_WITH_TXS because the description says that it is a list of full transactions.

BLOCK_BODY_WITH_TXS:

starknet-specs/api/starknet_api_openrpc.json

Lines 1376 to 1397 in 304b952

"items": {
"title": "transactions in block",
"type": "object",
"allOf": [
{
"title": "transaction",
"$ref": "#/components/schemas/TXN"
},
{
"type": "object",
"properties": {
"transaction_hash": {
"title": "transaction hash",
"$ref": "#/components/schemas/TXN_HASH"
}
},
"required": [
"transaction_hash"
]
}
]
}

BLOCK_BODY_WITH_RECEIPTS:

starknet-specs/api/starknet_api_openrpc.json

Lines 1412 to 1429 in 304b952

"items": {
"type": "object",
"title": "transaction and receipt",
"properties": {
"transaction": {
"title": "transaction",
"$ref": "#/components/schemas/TXN"
},
"receipt": {
"title": "receipt",
"$ref": "#/components/schemas/TXN_RECEIPT"
}
},
"required": [
"transaction",
"receipt"
]
}

@thiagodeev thiagodeev mentioned this issue Jun 28, 2024
Open
@ArielElp
Copy link
Collaborator

The reason that it was not included was that the transaction receipt already includes the hash, hence it would be duplicated information in this request.

@ArielElp ArielElp closed this as not planned Won't fix, can't repro, duplicate, stale Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add txHash field to the BLOCK_BODY_WITH_RECEIPTS scheme thiagodeev/starknet-specs
2 participants
@thiagodeev @ArielElp