Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plan to integrate FXAA or SMAA into default rendering ? #1

Open
zen253230 opened this issue May 20, 2024 · 1 comment
Open

Any plan to integrate FXAA or SMAA into default rendering ? #1

zen253230 opened this issue May 20, 2024 · 1 comment

Comments

@zen253230
Copy link

Hello,

you did a tremendous job exposing the osmesa api into a portable version ! Thank you !
But problem is antialiasing in rendered images.

VTK is using FXAA to overcome this problem :
https://github.com/Kitware/VTK/blob/master/Rendering/OpenGL2/glsl/vtkFXAAFilterFS.glsl
There is also SMAA :
https://github.com/iryoku/smaa/blob/master/SMAA.hlsl

Would you consider applying any of these two solutions into your examples?

@starseeker
Copy link
Owner

starseeker commented May 20, 2024

Thank you - I'm glad others are finding it to be of interest!

If anyone wants to submit a pull request to update the examples to use an improved filter like that I certainly wouldn't be opposed. Unfortunately my use case - BRL-CAD - doesn't use shaders in its primary drawing path (our current code is based on OpenGL code so old it actually pre-dates the name OpenGL) so I'm afraid I don't have much experience with setting up or using shaders.

If we were to update the BRL-CAD drawing code to use more modern OpenGL (for some peculiar value of the word "modern", given osmesa tops out at v2.1) we could certainly look into using one of those solutions for improved results, but unfortunately it's not likely to be a priority in the near term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants