Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for URI Model Identifiers (Or any containing .) #723

Open
wip-abramson opened this issue Jul 13, 2021 · 1 comment
Open

Add Support for URI Model Identifiers (Or any containing .) #723

wip-abramson opened this issue Jul 13, 2021 · 1 comment

Comments

@wip-abramson
Copy link

We are hoping to use StartupJs to interact with JSON-LD objects, where all our ids will be URIs.

We have opened an issue in racer - derbyjs/racer#289 and are working to add support for this.

However, it is likely that some changes will be required in StartupJs. I think in the orm library. Although thoughts on any other changes required would be welcome.

Opening this to explore whether StartupJs would be open to adopting a P.R for these changes

@cray0000
Copy link
Member

@wip-abramson sure, we'll be happy to work with you on merging that change in.

Judging from what Eric said in the original racer issue though it seems that it might break the functionality of reactive functions, refs and the model.on() event listeners. I don't think they are being used much anywhere in the startupjs codebase itself, but we use it in our own end-user projects.

We also plan to add the useStart() hook soon to be able to work with model.start() reactive functions easily, which is basically racer's alternative to computed from MobX. So reactive functions and refs are an important piece of racer's functionality and it would be great if the addition of JSON-LD support won't break the existing racer APIs.

If keeping refs and reactive functions and model.on() support is gonna be tricky though, an alternative solution might be to have the JSON-LD support as a flag which can be turned on in the @startupjs/init by passing an option to init() on server/client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants