Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when making square/long objects #23

Open
nataliakoliou opened this issue Jan 29, 2024 · 0 comments · May be fixed by #26
Open

Error when making square/long objects #23

nataliakoliou opened this issue Jan 29, 2024 · 0 comments · May be fixed by #26

Comments

@nataliakoliou
Copy link
Contributor

The current implementations of the make_square and make_long functions may result in errors, as the generated square or long shape could exceed the specified max_dim limit along the x or y axis. This issue arises from the calculation of the ending positions (x2/y2) being derived from the starting positions (x1/y1) and delta, which could potentially be 99. Therefore the ending positions may exceed 100.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant