Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove getContactDetailsAsJson and simplify flows where it's used #16717

Open
micieslak opened this issue Nov 5, 2024 · 0 comments · May be fixed by #16734
Open

Remove getContactDetailsAsJson and simplify flows where it's used #16717

micieslak opened this issue Nov 5, 2024 · 0 comments · May be fixed by #16734

Comments

@micieslak
Copy link
Member

Description

This issue assumes removing getContactDetailsAsJson from multiple places, replacing it with other approaches, depending on the context:

  • MembersTabPanel, ContactsView, MessageView - when requesting popup, only the pupKey should be needed, it's the side handling signal responsible to fetch whatever is needed for given popup. It allows to reduce dependency between the component requesting the popup and the popup itself
  • TokenHolderListItem - necessary data should be provided via the model, UI component, especially on the delegate level should not call backend directly
  • AddEditSavedAddressPopup.qml the flow should be revised, probably the validation should be externalized
  • Activity Center - providing contact info via models instead of accessing them on low-level
  • SendContactRequestModal - for further investigation (especially in context of Refactor contacts models to have a single model, remove useless properties and improve updating #16667)

Removing getContactDetailsAsJson, especially from low-level UI components is necessary to reduce dependency on backend and improve isolation. It's also blocker for further simplification like proposed in #16667

Related issue: #16667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Code Review
Development

Successfully merging a pull request may close this issue.

1 participant