You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue assumes removing getContactDetailsAsJson from multiple places, replacing it with other approaches, depending on the context:
MembersTabPanel, ContactsView, MessageView - when requesting popup, only the pupKey should be needed, it's the side handling signal responsible to fetch whatever is needed for given popup. It allows to reduce dependency between the component requesting the popup and the popup itself
TokenHolderListItem - necessary data should be provided via the model, UI component, especially on the delegate level should not call backend directly
AddEditSavedAddressPopup.qml the flow should be revised, probably the validation should be externalized
Activity Center - providing contact info via models instead of accessing them on low-level
Removing getContactDetailsAsJson, especially from low-level UI components is necessary to reduce dependency on backend and improve isolation. It's also blocker for further simplification like proposed in #16667
Description
This issue assumes removing
getContactDetailsAsJson
from multiple places, replacing it with other approaches, depending on the context:MembersTabPanel
,ContactsView
,MessageView
- when requesting popup, only the pupKey should be needed, it's the side handling signal responsible to fetch whatever is needed for given popup. It allows to reduce dependency between the component requesting the popup and the popup itselfTokenHolderListItem
- necessary data should be provided via the model, UI component, especially on the delegate level should not call backend directlyAddEditSavedAddressPopup.qml
the flow should be revised, probably the validation should be externalizedSendContactRequestModal
- for further investigation (especially in context of Refactor contacts models to have a single model, remove useless properties and improve updating #16667)Removing
getContactDetailsAsJson
, especially from low-level UI components is necessary to reduce dependency on backend and improve isolation. It's also blocker for further simplification like proposed in #16667Related issue: #16667
The text was updated successfully, but these errors were encountered: