-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix loadNodeConfig loses DB data #5597
Comments
friofry
added a commit
to status-im/status-desktop
that referenced
this issue
Jul 26, 2024
Fixes #14929 Correct fix should be done as part of status-im/status-go#5597 after dependency tasks are done
friofry
added a commit
to status-im/status-desktop
that referenced
this issue
Jul 26, 2024
Fixes #14929 Correct fix should be done as part of status-im/status-go#5597 after dependency tasks are done
friofry
added a commit
to status-im/status-desktop
that referenced
this issue
Jul 26, 2024
Fixes #14929 Correct fix should be done as part of status-im/status-go#5597 after dependency tasks are done (cherry picked from commit ac04e34)
jrainville
pushed a commit
to status-im/status-desktop
that referenced
this issue
Jul 29, 2024
#15838) Fixes #14929 Correct fix should be done as part of status-im/status-go#5597 after dependency tasks are done (cherry picked from commit ac04e34)
I think it's time to fix this. I'm facing another issue trying to pass
It works on the first run, but on the next Login it overwrites the saved networks with the defaults. @friofry wanna get back to this issue and try to fix it again? 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
As mentioned in status-im/status-desktop#14929
OverwriteNodeConfigValues
loses some data (LogLevel, Waku nodes).Here is an initial fix: #5527
Since
loadNodeConfig
is used in different ways in different places, this ticket should be done after #5563 (make paths in NodeConfig consistent) becauseconf.DataDir = filepath.Join(b.rootDataDir, conf.DataDir)
joins 2 absolute paths in some tests.Another issue: we load the DataDir from the db in
conf, err := nodecfg.GetNodeConfigFromDB(b.appDB)
, thenmerge it with the default config
conf, err = b.OverwriteNodeConfigValues(inputNodeCfg, conf)
(it saves the merged config to the database). But only after that theDataDir
is joined with theconf.rootDataDir
. Some tests might fail because they contain "../static/test-account" in the DataDir (TestLoginAndMigrationsStillWorkWithExistingDesktopUser
).Implementation
Implement #5563, reuse #5527, fix tests
Notes
from #5527 (review)
The text was updated successfully, but these errors were encountered: