You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@antdanchenko raised a risk of potential leak of credentials in functional test logs, if we pass them through API.
I discussed it today with @osmaczko.
Even if we embed it to status-go during build time, anyway there's always a risk of leaking it in geth.log itself.
So we agreed not to overcomplicate things now and pass the credentials through API.
At the same time, we must implement right tools to prevent leaks. We discussed these options:
Read these env vars:
STATUS_BUILD_PROXY_USER
STATUS_BUILD_PROXY_PASSWORD
Pass values to these endpoints as part of
WalletSecretsConfig
:CreateAccountAndLogin
RestoreAccountAndLogin
LoginAccount
status-go/params/config.go
Lines 551 to 556 in 29bf0d6
Reference status-desktop for correspondence of env vars to parameters:
https://github.com/status-im/status-desktop/blob/73af1b8ba0fd82a5259a5799fef3bd03280869b3/src/app_service/service/accounts/service.nim#L168-L172
Also set
WalletSecretsConfig.statusProxyStageName
to"test"
.The text was updated successfully, but these errors were encountered: