Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_: set proxy creds #6211

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

test_: set proxy creds #6211

wants to merge 3 commits into from
+19 −0

Conversation

antdanchenko
Copy link
Contributor

@antdanchenko antdanchenko commented Dec 13, 2024 •
edited by igor-sirotin
Loading

Closes #6144

@status-im-auto
Copy link
Member

status-im-auto commented Dec 13, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (8)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ ea340d2 #1 2024-12-13 10:33:19 ~4 min macos 📦zip
✔️ ea340d2 #1 2024-12-13 10:33:36 ~4 min ios 📦zip
✔️ ea340d2 #1 2024-12-13 10:34:11 ~5 min linux 📦zip
✔️ ea340d2 #1 2024-12-13 10:34:18 ~5 min android 📦aar
✔️ ea340d2 #1 2024-12-13 10:34:27 ~5 min windows 📦zip
✔️ ea340d2 #1 2024-12-13 10:35:06 ~6 min tests-rpc 📄log
✔️ ea340d2 #1 2024-12-13 10:36:58 ~8 min macos 📦zip
✔️ ea340d2 #1 2024-12-13 10:59:23 ~30 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3c39fec #2 2024-12-13 12:17:09 ~3 min windows 📦zip
✔️ 3c39fec #2 2024-12-13 12:17:36 ~4 min macos 📦zip
✔️ 3c39fec #2 2024-12-13 12:18:05 ~4 min ios 📦zip
✔️ 3c39fec #2 2024-12-13 12:18:23 ~5 min linux 📦zip
✔️ 3c39fec #2 2024-12-13 12:18:36 ~5 min android 📦aar
✔️ 3c39fec #2 2024-12-13 12:19:14 ~6 min tests-rpc 📄log
✔️ 3c39fec #2 2024-12-13 12:21:52 ~8 min macos 📦zip
✔️ 3c39fec #2 2024-12-13 12:42:20 ~29 min tests 📄log
✔️ ee14490 #3 2024-12-13 12:57:27 ~3 min macos 📦zip
✔️ ee14490 #3 2024-12-13 12:57:50 ~3 min windows 📦zip
✖️ ee14490 #3 2024-12-13 12:57:57 ~3 min tests-rpc 📄log
✔️ ee14490 #3 2024-12-13 12:58:28 ~4 min ios 📦zip
✔️ ee14490 #3 2024-12-13 12:58:34 ~4 min linux 📦zip
✔️ ee14490 #3 2024-12-13 12:59:18 ~5 min android 📦aar
✔️ ee14490 #3 2024-12-13 13:01:59 ~8 min macos 📦zip
✔️ ee14490 #3 2024-12-13 13:24:27 ~30 min tests 📄log

@codecov Codecov
Copy link

codecov bot commented Dec 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.07%. Comparing base (74db631) to head (ee14490).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #6211      +/-   ##
===========================================
- Coverage    61.27%   60.07%   -1.20%     
===========================================
  Files          833      833              
  Lines       109910   109910              
===========================================
- Hits         67348    66032    -1316     
- Misses       34711    36121    +1410     
+ Partials      7851     7757      -94
Flag Coverage Δ
functional 0.82% <ø> (-18.52%) ⬇️
unit 60.03% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 95 files with indirect coverage changes

igor-sirotin
igor-sirotin reviewed Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@igor-sirotin igor-sirotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antdanchenko this also needs to be set in LoginAccount:

status-go/tests-functional/clients/status_backend.py

Lines 180 to 187 in 1795620

def login(self, keyUid, user=user_1):
method = "LoginAccount"
data = {
"password": user.password,
"keyUid": keyUid,
"kdfIterations": 256000,
}

status-go/protocol/requests/login.go

Line 36 in b74d9e6

WalletSecretsConfig

tests-functional/clients/status_backend.py Outdated Show resolved Hide resolved
igor-sirotin
igor-sirotin approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@igor-sirotin igor-sirotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@github-actions GitHub Actions
Copy link

We require commits to follow the Conventional Commits, but with _ for non-breaking changes.
Please fix these commit messages:

test:_ check if vars exist

@mendelskiv93 mendelskiv93 mentioned this pull request Dec 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anastasiyaig anastasiyaig anastasiyaig approved these changes

@igor-sirotin igor-sirotin igor-sirotin approved these changes

@yevh-berdnyk yevh-berdnyk Awaiting requested review from yevh-berdnyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set proxy credentials from functional tests
4 participants
@antdanchenko @status-im-auto @igor-sirotin @anastasiyaig